Bug 414536 - krita 4.2.8.1 has a wrong Qt version check
Summary: krita 4.2.8.1 has a wrong Qt version check
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: General (show other bugs)
Version: 4.2.8
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-26 12:47 UTC by Wolfgang Bauer
Modified: 2019-11-26 14:36 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wolfgang Bauer 2019-11-26 12:47:57 UTC
https://cgit.kde.org/krita.git/commit/?h=krita/4.2&id=07554913b16417792f390e061560e63cfdfa52a3 is wrong.

When building against Qt 5.9 it fails:
/home/abuild/rpmbuild/BUILD/krita-4.2.8.1/krita/main.cc: In function 'int main(int, char**)':
/home/abuild/rpmbuild/BUILD/krita-4.2.8.1/krita/main.cc:421:26: error: 'AA_DisableWindowContextHelpButton' is not a member of 'Qt'
     app.setAttribute(Qt::AA_DisableWindowContextHelpButton);
                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

And it certainly doesn't do the right thing when building against newer versions either... ;-)

It should rather be:
#if (QT_VERSION >= QT_VERSION_CHECK(5, 10, 0))
Comment 1 Halla Rempt 2019-11-26 13:26:47 UTC
Git commit 22a6b1d23aa5b2b997fac17bfbb647779a679856 by Boudewijn Rempt.
Committed on 26/11/2019 at 13:25.
Pushed by rempt into branch 'krita/4.2'.

M  +1    -1    krita/main.cc

https://invent.kde.org/kde/krita/commit/22a6b1d23aa5b2b997fac17bfbb647779a679856
Comment 2 Halla Rempt 2019-11-26 13:28:00 UTC
Git commit d19b0b6c5f88c7c9f276cecf595f1da566041bcc by Boudewijn Rempt.
Committed on 26/11/2019 at 13:27.
Pushed by rempt into branch 'master'.

M  +1    -1    krita/main.cc

https://invent.kde.org/kde/krita/commit/d19b0b6c5f88c7c9f276cecf595f1da566041bcc
Comment 3 Dmitry Kazakov 2019-11-26 14:03:49 UTC
Hi, Boud!

Could you please make the new tarballs with version 4.2.8.2? Otherwise all the builders will have to wait until tomorrow because of mirrors, that will keep the old version for about 5 hours.
Comment 4 Halla Rempt 2019-11-26 14:36:36 UTC
I will be home around 17:00 CET, I cannot make tarballs on the train.