Bug 414494 - Kompare doesn't compile against Qt 5.14
Summary: Kompare doesn't compile against Qt 5.14
Status: RESOLVED FIXED
Alias: None
Product: kompare
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Kompare developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-25 12:26 UTC by bluescreenavenger
Modified: 2019-12-19 16:09 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/kompare/e2869a95ca955426f24e6f1a800e64ba620a43a8
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description bluescreenavenger 2019-11-25 12:26:59 UTC 
Using master branch, it seems I get a build error compiling against Qt 5.14


[ 82%] Building CXX object komparepart/CMakeFiles/komparepart.dir/komparelistview.cpp.o
[ 84%] Building CXX object komparepart/CMakeFiles/komparepart.dir/kompareprefdlg.cpp.o
[ 86%] Building CXX object komparepart/CMakeFiles/komparepart.dir/komparesaveoptionsbase.cpp.o
/srcbuild/kompare/komparepart/komparesplitter.cpp: In member function ‘virtual void KompareSplitter::wheelEvent(QWheelEvent*)’:
/srcbuild/kompare/komparepart/komparesplitter.cpp:252:12: error: ‘class QWheelEvent’ has no member named ‘orientation’
     if (e->orientation() == Qt::Vertical)
            ^~~~~~~~~~~
/srcbuild/kompare/komparepart/komparesplitter.cpp:255:20: error: ‘class QWheelEvent’ has no member named ‘delta’
             if (e->delta() < 0)   // scroll down one page
                    ^~~~~
/srcbuild/kompare/komparepart/komparesplitter.cpp:260:20: error: ‘class QWheelEvent’ has no member named ‘delta’
             if (e->delta() < 0)   // scroll down
                    ^~~~~
/srcbuild/kompare/komparepart/komparesplitter.cpp:269:20: error: ‘class QWheelEvent’ has no member named ‘delta’
             if (e->delta() < 0)   // scroll right one page
                    ^~~~~
/srcbuild/kompare/komparepart/komparesplitter.cpp:274:20: error: ‘class QWheelEvent’ has no member named ‘delta’
             if (e->delta() < 0)   // scroll to the right
                    ^~~~~
[ 88%] Building CXX object komparepart/CMakeFiles/komparepart.dir/komparesaveoptionswidget.cpp.o
[ 91%] Building CXX object komparepart/CMakeFiles/komparepart.dir/kompareview.cpp.o
make[2]: *** [komparepart/CMakeFiles/komparepart.dir/build.make:125: komparepart/CMakeFiles/komparepart.dir/komparesplitter.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
[ 93%] Linking CXX executable bin/kompare
[ 93%] Built target kompare
/srcbuild/kompare/komparepart/komparesaveoptionswidget.cpp: In constructor ‘KompareSaveOptionsWidget::KompareSaveOptionsWidget(const QString&, const QString&, DiffSettings*, QWidget*)’:
/srcbuild/kompare/komparepart/komparesaveoptionswidget.cpp:78:105: error: invalid static_cast from type ‘void (QSpinBox::*)(int)’ to type ‘void (QSpinBox::*)(const QString&)’
     connect(m_ContextLinesSB,     static_cast<void(QSpinBox::*)(const QString&)>(&QSpinBox::valueChanged),
                                                                                                         ^
make[2]: *** [komparepart/CMakeFiles/komparepart.dir/build.make:177: komparepart/CMakeFiles/komparepart.dir/komparesaveoptionswidget.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:531: komparepart/CMakeFiles/komparepart.dir/all] Error 2
make: *** [Makefile:141: all] Error 2
Comment 1 Kevin Kofler 2019-11-25 13:52:08 UTC 
Please revert:
https://cgit.kde.org/kompare.git/commit/?id=355ae0ef3d39cbe3958024de3e35cf6d12780c52
for the time being. (QT_DISABLE_DEPRECATED_BEFORE=0x060000 is a moving target as long as there are still 5.x releases that can deprecate things, as happened here.)
Comment 2 Christoph Feck 2019-12-19 16:09:56 UTC 
Should be fixed with https://commits.kde.org/kompare/e2869a95ca955426f24e6f1a800e64ba620a43a8