Bug 414493 - kdecorations doesn't build with Qt 5.14
Summary: kdecorations doesn't build with Qt 5.14
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: decorations (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-25 12:24 UTC by bluescreenavenger
Modified: 2019-11-25 12:42 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/kdecoration/dc45cf7a1d35d4c728c7999b02e0ccdde4653b58
Version Fixed In:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description bluescreenavenger 2019-11-25 12:24:45 UTC 
Hi

It seems I get this error while building against Qt 5.14


[ 35%] Building CXX object src/CMakeFiles/kdecorations2.dir/decorationshadow.cpp.o
[ 37%] Building CXX object src/CMakeFiles/kdecorations2.dir/decoratedclient.cpp.o
/srcbuild/kdecoration/src/decoration.cpp: In member function ‘virtual void KDecoration2::Decoration::wheelEvent(QWheelEvent*)’:
/srcbuild/kdecoration/src/decoration.cpp:386:37: error: ‘class QWheelEvent’ has no member named ‘posF’
         if (button->contains(event->posF())) {
                                     ^~~~
make[2]: *** [src/CMakeFiles/kdecorations2.dir/build.make:89: src/CMakeFiles/kdecorations2.dir/decoration.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/srcbuild/kdecoration/src/decorationbutton.cpp: In member function ‘void KDecoration2::DecorationButton::Private::init()’:
/srcbuild/kdecoration/src/decorationbutton.cpp:67:35: error: ‘class QWeakPointer<KDecoration2::DecoratedClient>’ has no member named ‘data’; did you mean ‘Data’?
     auto c = decoration->client().data();
                                   ^~~~
                                   Data
make[2]: *** [src/CMakeFiles/kdecorations2.dir/build.make:102: src/CMakeFiles/kdecorations2.dir/decorationbutton.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:229: src/CMakeFiles/kdecorations2.dir/all] Error 2
make: *** [Makefile:141: all] Error 2
Comment 1 David Edmundson 2019-11-25 12:37:12 UTC 
FWIW, the release will.

It's this weird line:

if (EXISTS "${CMAKE_SOURCE_DIR}/.git")
   add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x060000)
   add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x060000)
endif()


Which has caused other problems for us
Comment 2 David Edmundson 2019-11-25 12:42:30 UTC 
Git commit dc45cf7a1d35d4c728c7999b02e0ccdde4653b58 by David Edmundson.
Committed on 25/11/2019 at 12:41.
Pushed by davidedmundson into branch 'master'.

Revert "GIT_SILENT: it compiles fine without deprecated method"

This reverts commit 8e5c8acadbd5a69ec8e3ecdfaf9b168ff22579ae.

This breaks the build.

Also can we take this to the ML first.
Kossebau says we should be doing something different

M  +0    -4    CMakeLists.txt

https://commits.kde.org/kdecoration/dc45cf7a1d35d4c728c7999b02e0ccdde4653b58