Bug 414487 - Huge album art on Plasma lock screen with media controls enabled
Summary: Huge album art on Plasma lock screen with media controls enabled
Status: RESOLVED FIXED
Alias: None
Product: kscreenlocker
Classification: Plasma
Component: breeze-theme (show other bugs)
Version: unspecified
Platform: Debian unstable Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2019-11-25 10:16 UTC by Apurv
Modified: 2019-11-25 12:43 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.17.4


Attachments
It's a picture taken using my phone camera, showing how the album art is huge because of having multiple lines in the name of whatever file is being played (3.24 MB, image/jpeg)
2019-11-25 10:16 UTC, Apurv
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Apurv 2019-11-25 10:16:35 UTC
Created attachment 124110 [details]
It's a picture taken using my phone camera, showing how the album art is huge because of having multiple lines in the name of whatever file is being played

SUMMARY
I observed this broken layout when I was playing an episode from Mozilla:IRL podcast on Clementine. When I locked the screen, and returned to unlock it, the layout was messed up. Thumbnail was huge, and that probably changed dimensions and position of play/pause button as well.


STEPS TO REPRODUCE
Play "Checking out online shopping..." podcast episode on clementine from Mozilla:IRL podcast

OBSERVED RESULT
Huge album art and play/pause button

EXPECTED RESULT
Album thumbnail shouldn't have been double of its size.


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Debian Sid
KDE Plasma Version: 5.14.5
KDE Frameworks Version: 5.62.0
Qt Version: 5.12.5
Comment 1 Kai Uwe Broulik 2019-11-25 10:27:34 UTC
lol what kind of track title is that even :D I thought there was a line limit on those :/
Comment 2 Apurv 2019-11-25 10:29:11 UTC
Yeah, I was wondering the same. However insane it was named, it helped in figuring out an issue :D
Comment 3 Kai Uwe Broulik 2019-11-25 10:39:24 UTC
Probably just needs a maximumLineCount: 1 in plasma-workspace/lookandfeel/contents/lockscreen/LockScreenUi.qml

Does it cause problems elsewhere, too? Like in task manager tooltips or Media Controller plasmoid?
Comment 4 Apurv 2019-11-25 10:48:26 UTC
Yeah, just noticed that it's also breaking consistency with tooltips in task manager and the desktop notification gets huge. I guess there have to be some sort of line check to cover this weird edge case scenario
Comment 5 Kai Uwe Broulik 2019-11-25 11:19:21 UTC
Feel free to file bug reports for the other issues, too, if you want :)
Comment 6 Apurv 2019-11-25 11:31:39 UTC
I can try to play around and see if it can be fixed. Looks like a good place to get into KDE development. Where can I get the source from? And a quickstart guide?
Comment 7 Apurv 2019-11-25 12:26:50 UTC
I've submitted a patch (https://phabricator.kde.org/D25519), and I don't know what else to do or if there's anything else that I need to do or not
Comment 8 Kai Uwe Broulik 2019-11-25 12:43:50 UTC
Git commit e2cbf51aa5165303455733f63f3f390ada2f9da4 by Kai Uwe Broulik, on behalf of Apurv Jyotirmay.
Committed on 25/11/2019 at 12:43.
Pushed by broulik into branch 'Plasma/5.17'.

Fix broken multimedia control on lockscreen
FIXED-IN: 5.17.4

Differential Revision: https://phabricator.kde.org/D25519

M  +2    -0    lookandfeel/contents/lockscreen/MediaControls.qml

https://commits.kde.org/plasma-workspace/e2cbf51aa5165303455733f63f3f390ada2f9da4