Bug 414410 - "Open containing folder feature" using KIO::highlightInFileManager() does not work in Windows
Summary: "Open containing folder feature" using KIO::highlightInFileManager() does not...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-kio
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: 5.64.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Christoph Cullmann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-23 01:47 UTC by Jose María Galdós
Modified: 2020-05-31 15:46 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.71
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Jose María Galdós 2019-11-23 01:47:16 UTC 
SUMMARY


STEPS TO REPRODUCE
1. Install Okular from Windows Store
2. Open a pdf
3. Select File > Open Containing Folder.

OBSERVED RESULT
Nothing happens.

EXPECTED RESULT
New Windows Explorer opens where pdf is located.

SOFTWARE/OS VERSIONS
Windows: 1909
KDE Frameworks Version: 5.63.0
Qt Version: 5.13.1
Okular Version: 1.8.2
Comment 1 Nate Graham 2019-11-23 18:32:19 UTC 
This menu item calls KIO::highlightInFileManager. I guess that function doesn't work on Windows.
Comment 2 Kai Uwe Broulik 2019-11-23 18:44:23 UTC 
Anyone knowledgeable in Windows just needs to implement a open strategy calling SHOpenFolderAndSelectItems
Comment 3 Kai Uwe Broulik 2019-11-23 18:46:08 UTC 
In any case it should already have a fallback for opening just the parent folder without highlighting the file, which might then also be broken?
Comment 4 Ahmad Samir 2020-05-31 15:46:15 UTC 
OpenFileManagerWindowJob has been ported to KIO::OpenUrlJob, the latter has a fallback to use QDesktopServices::openUrl() which should work on windows.

https://invent.kde.org/frameworks/kio/-/blob/master/src/gui/openurljob.cpp#L617

Closing as fixed, feel free to reopen if you still see this issue with KIO 5.71.0  which is going to be released in a couple of weeks: https://community.kde.org/Schedules/Frameworks