Bug 414402 - Dolphin service fails to spawn a new instance of Dolphin
Summary: Dolphin service fails to spawn a new instance of Dolphin
Status: RESOLVED FIXED
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 19.08.3
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-22 19:15 UTC by frontlemon
Modified: 2019-11-28 20:54 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 19.12.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description frontlemon 2019-11-22 19:15:15 UTC
SUMMARY
Dolphin service fails to spawn a new instance of Dolphin.

STEPS TO REPRODUCE
1. Open Firefox and open the downloads section (Ctrl+Shift+Y). Open a downloaded file using "Open containing folder": Dolphin opens with the file highlighted. Close Dolphin.

2. Open a standalone Dolphin from "Application Menu". In Firefox, again open a downloaded file using "Open containing folder": the standalone Dolphin opens the file highlighted in a separate tab. Fully close Dolphin.

3. Subsequently, open any downloaded file in Firefox using "Open containing folder".

OBSERVED RESULT
If subsequent downloaded files are opened in Firefox using "Open containing folder", nothing happens.

EXPECTED RESULT
If subsequent downloaded files are opened in Firefox using "Open containing folder", Dolphin should open with the said file highlighted.

SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux 
KDE Plasma Version: 5.17.3
KDE Frameworks Version: 5.64.0
Qt Version: 5.13.2
Kernel Version: 5.3.11-1-MANJARO
OS Type: 64-bit


ADDITIONAL INFORMATION
Comment 1 Elvis Angelaccio 2019-11-24 12:32:05 UTC
Cannot reproduce here.

> 2. Open a standalone Dolphin from "Application Menu". In Firefox, again open
> a downloaded file using "Open containing folder": the standalone Dolphin
> opens the file highlighted in a separate tab. Fully close Dolphin.

What do you mean with "Fully close" here? Even if you close the standalone Dolphin, you should still have a "dolphin --deamon" process around which will take care of Firefox's requests.
Comment 2 Elvis Angelaccio 2019-11-24 13:39:54 UTC
Actually, I can reproduce it in a X11 session (I was trying in a Wayland session before).
Comment 3 frontlemon 2019-11-25 00:08:30 UTC
(In reply to Elvis Angelaccio from comment #1)
> Cannot reproduce here.
> 
> > 2. Open a standalone Dolphin from "Application Menu". In Firefox, again open
> > a downloaded file using "Open containing folder": the standalone Dolphin
> > opens the file highlighted in a separate tab. Fully close Dolphin.
> 
> What do you mean with "Fully close" here? Even if you close the standalone
> Dolphin, you should still have a "dolphin --deamon" process around which
> will take care of Firefox's requests.

The "dolphin --daemon" process should keep on running. "Fully close" means fully closed from view.
Comment 4 Elvis Angelaccio 2019-11-28 20:54:46 UTC
Git commit 089a05b4edfd7a70e50ed7d8b158cbcc50538d36 by Elvis Angelaccio.
Committed on 28/11/2019 at 20:52.
Pushed by elvisangelaccio into branch 'release/19.12'.

Force dbus introspection on the Dolphin_1 object

Summary:
QtDBus caches known interfaces when passing a non-empty interface name
to the QDbusInterface constructor. This is an issue when calling the
FileManager1 methods more than once, because `preferred` could be a
valid interface from the cache, but it would later fail to call the
`openFiles`/`openDirectories` methods on the main window.

By passing an empty interface name, we prevent QtDBus from using the
cache so that we always get an invalid interface when calling the
FileManager1 methods on a daemonized dolphin process (that doesn't have
the Dolphin_1 dbus object).
FIXED-IN: 19.12.0

Test Plan:
1. dolphin --daemon
2. qdbus org.freedesktop.FileManager1 /org/freedesktop/FileManager1 ShowFolders "/tmp" ""
3. Close the dolphin window that was just opened.
4. Start a normal dolphin process
5. qdbus org.freedesktop.FileManager1 /org/freedesktop/FileManager1 ShowFolders "/tmp" ""
6. Close again the dolphin window
7. qdbus org.freedesktop.FileManager1 /org/freedesktop/FileManager1 ShowFolders "/tmp" ""

Subscribers: kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D25510

M  +1    -1    src/global.cpp

https://commits.kde.org/dolphin/089a05b4edfd7a70e50ed7d8b158cbcc50538d36