Bug 414340 - RawTherapee plugin
Summary: RawTherapee plugin
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-RawImport-Rawtherapee (show other bugs)
Version: 6.4.0
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-20 19:14 UTC by Andrius
Modified: 2022-01-26 04:18 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 7.0.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrius 2019-11-20 19:14:17 UTC
Hello,
digikam 6.4.0 on Windows 10.
I tried using either RawTherapee or darktable as raw processors in didiKam but it did not work.
When I press F4 or click on "Editor" button the Image Editor window pops up but nothing happens in there.

[1089332] digikam.geoiface: ---- [1089332] digikam.general: RawTherapee arguments: ("-gimp", “C:/Users/wca0272/Desktop/New import/2019-08/IMGP6784.DNG”, “C:/Users/user/AppData/Local/Temp/digikam.DqzhxW”) [1089332] digikam.general: RawTherapee :: Process has failed to start

If I select the default (libraw) everything works.

Is there a way to point digiKam to RawTherapee installed in my system?
Comment 1 caulier.gilles 2019-11-20 19:23:36 UTC
>Is there a way to point digiKam to RawTherapee installed in my system?

Not yet. executable must be in the PATH which is mostly the case.

But in fact the problem is very simple : 

https://invent.kde.org/kde/digikam/blob/master/core/dplugins/rawimport/rawtherapee/rawimportrawtherapeeplugin.cpp#L147

Program name under Windows must use .exe extension (:-))). This is true for Darktable and Ufraw... It's very simple to fix.

Libraw do not start an external problem but it relevant of a C++ library. It's completely different.

Gilles Caulier
Comment 2 Andrius 2019-11-20 19:39:08 UTC
(In reply to caulier.gilles from comment #1)
> >Is there a way to point digiKam to RawTherapee installed in my system?
> 
> Not yet. executable must be in the PATH which is mostly the case.
> 
> But in fact the problem is very simple : 
> 
> https://invent.kde.org/kde/digikam/blob/master/core/dplugins/rawimport/
> rawtherapee/rawimportrawtherapeeplugin.cpp#L147
> 
> Program name under Windows must use .exe extension (:-))). This is true for
> Darktable and Ufraw... It's very simple to fix.
> 
> Libraw do not start an external problem but it relevant of a C++ library.
> It's completely different.
> 
> Gilles Caulier

My path to RawTherapee is:
"C:\Program Files\RawTherapee\5.4\rawtherapee.exe"
Comment 3 Maik Qualmann 2019-11-20 20:57:45 UTC
Git commit ffb51059d9c3e9d6cb41c7c1f348b08094646431 by Maik Qualmann.
Committed on 20/11/2019 at 20:56.
Pushed by mqualmann into branch 'master'.

first try to start rawtherapee under Windows

M  +20   -11   core/dplugins/rawimport/rawtherapee/rawimportrawtherapeeplugin.cpp

https://invent.kde.org/kde/digikam/commit/ffb51059d9c3e9d6cb41c7c1f348b08094646431
Comment 4 Maik Qualmann 2019-11-22 10:28:22 UTC
RawTherapee now starts correctly under Windows, but does not create the file in the TMP directory after closing. The empty TMP file must not exist under Windows.

Maik
Comment 5 Maik Qualmann 2019-11-22 10:50:16 UTC
Git commit b4b125b7477a1d535ad1d194a8a64e166a98e3ce by Maik Qualmann.
Committed on 22/11/2019 at 10:49.
Pushed by mqualmann into branch 'master'.

fix temporary file for RawTherapee

M  +11   -14   core/dplugins/rawimport/rawtherapee/rawimportrawtherapeeplugin.cpp

https://invent.kde.org/kde/digikam/commit/b4b125b7477a1d535ad1d194a8a64e166a98e3ce
Comment 6 Maik Qualmann 2019-11-23 16:38:50 UTC
RawTherapee plugin works now fine under Windows.

Maik
Comment 7 Maik Qualmann 2019-11-25 08:59:28 UTC
*** Bug 414484 has been marked as a duplicate of this bug. ***