Bug 414336 - Resizing vector shapes is jumpy, flickery when 'Snap Orthogonal' option is on
Summary: Resizing vector shapes is jumpy, flickery when 'Snap Orthogonal' option is on
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools/Vector (show other bugs)
Version: nightly build (please specify the git hash!)
Platform: Microsoft Windows Microsoft Windows
: NOR minor
Target Milestone: ---
Assignee: Dmitry Kazakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-20 18:20 UTC by acc4commissions
Modified: 2020-06-11 21:51 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
There is no other vector shapes in the layer (156.66 KB, image/gif)
2019-11-20 18:20 UTC, acc4commissions
Details

Note You need to log in before you can comment on or make changes to this bug.
Description acc4commissions 2019-11-20 18:20:51 UTC
Created attachment 124030 [details]
There is no other vector shapes in the layer

SUMMARY


STEPS TO REPRODUCE
1. Create a vactor layer and a shape 
2. Try to resize

OBSERVED RESULT
It's jumpy as if there are millions of other shapes around it.

EXPECTED RESULT
It should be smooth.

SOFTWARE/OS VERSIONS
Windows: Win7
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 acc4commissions 2019-11-20 18:25:46 UTC
git f41bc3f
Comment 2 Raghavendra kamath 2019-11-20 18:35:49 UTC
I think this is a duplicate bug 411738 - https://bugs.kde.org/show_bug.cgi?id=411738
Comment 3 Raghavendra kamath 2019-11-20 18:36:37 UTC

*** This bug has been marked as a duplicate of bug 411738 ***
Comment 4 acc4commissions 2019-11-21 02:49:19 UTC
I don't think so... bug 411738 is already resolved in the latest nightly and this one is different. It doesn't happen when the snapping is off, and also the 'jumpiness' behaves differently. 

It might be related though, I wouldn' know. But it doesn't seem to be the same issue.
Comment 5 Dmitry Kazakov 2020-01-28 13:51:57 UTC
Git commit cf68ba07809b1ff775e71d1fe2cd7b3789b31c1f by Dmitry Kazakov.
Committed on 28/01/2020 at 13:51.
Pushed by dkazakov into branch 'master'.

Fix crazy snapping when resizing shapes

The snape shouldn't snap to itself. It looks crazy and unusable.

TODO: implement snapping of the shape to its original position. It
      can be done by adding a copy of the shape to KoSnapGuide, or
      by adding its nodes.

M  +1    -1    libs/flake/KoSnapStrategy.cpp

https://invent.kde.org/kde/krita/commit/cf68ba07809b1ff775e71d1fe2cd7b3789b31c1f
Comment 6 Dmitry Kazakov 2020-01-28 13:53:30 UTC
Git commit 5e5eb3b5d4e0864b52a5da05f03a41e4b5229758 by Dmitry Kazakov.
Committed on 28/01/2020 at 13:53.
Pushed by dkazakov into branch 'krita/4.2'.

Fix crazy snapping when resizing shapes

The snape shouldn't snap to itself. It looks crazy and unusable.

TODO: implement snapping of the shape to its original position. It
      can be done by adding a copy of the shape to KoSnapGuide, or
      by adding its nodes.

M  +1    -1    libs/flake/KoSnapStrategy.cpp

https://invent.kde.org/kde/krita/commit/5e5eb3b5d4e0864b52a5da05f03a41e4b5229758
Comment 7 Dmitry Kazakov 2020-01-28 13:56:25 UTC
Git commit 3aacc960448a3c73aaec66c5b469e6949522c32d by Dmitry Kazakov.
Committed on 28/01/2020 at 13:49.
Pushed by dkazakov into branch 'master'.

Fix crazy snapping when resizing shapes

The snape shouldn't snap to itself. It looks crazy and unusable.

TODO: implement snapping of the shape to its original position. It
      can be done by adding a copy of the shape to KoSnapGuide, or
      by adding its nodes.

M  +1    -1    libs/flake/KoSnapStrategy.cpp

https://invent.kde.org/kde/krita/commit/3aacc960448a3c73aaec66c5b469e6949522c32d
Comment 8 acc4commissions 2020-02-08 12:42:01 UTC
It still happens in git ba4e484.
Comment 9 acc4commissions 2020-03-02 06:32:50 UTC
Still happens in git a2452fc.
Comment 10 Dmitry Kazakov 2020-03-02 22:19:29 UTC
Hi, acc4commissions!

Could you please make some video of the problem? I cannot reproduce it in master :( Perhaps I do something wrongly...
Comment 11 Dmitry Kazakov 2020-06-11 21:30:46 UTC
Okay, I think I can reproduce the problem now.
Comment 12 acc4commissions 2020-06-11 21:42:17 UTC
(In reply to Dmitry Kazakov from comment #11)
> Okay, I think I can reproduce the problem now.

I'm sorry that I couldn't make a video. I've been checking my reports but must've missed this one.
Comment 13 Dmitry Kazakov 2020-06-11 21:50:53 UTC
Git commit a502ac08e4deeab06a6e3d76006e9a573a691202 by Dmitry Kazakov.
Committed on 11/06/2020 at 21:50.
Pushed by dkazakov into branch 'krita/4.3'.

Fix jumping of shapes when Orthogonal Snap is enabled

We shouldn't take the toplevel shape layer into account when looking
for targets for snapping. The layer is not represented anyhow in the
rendering tree and its bounding box may conincide with the one of its
children shapes.

M  +3    -1    libs/flake/KoSnapProxy.cpp

https://invent.kde.org/graphics/krita/commit/a502ac08e4deeab06a6e3d76006e9a573a691202
Comment 14 Dmitry Kazakov 2020-06-11 21:51:24 UTC
Git commit 4cb60201bab35dc382d62e893ab55f84fc503e79 by Dmitry Kazakov.
Committed on 11/06/2020 at 21:51.
Pushed by dkazakov into branch 'master'.

Fix jumping of shapes when Orthogonal Snap is enabled

We shouldn't take the toplevel shape layer into account when looking
for targets for snapping. The layer is not represented anyhow in the
rendering tree and its bounding box may conincide with the one of its
children shapes.

M  +3    -1    libs/flake/KoSnapProxy.cpp

https://invent.kde.org/graphics/krita/commit/4cb60201bab35dc382d62e893ab55f84fc503e79