I have a folder widget in my panel. When I expand it in list mode and select an item, the selection (background) color is correct but the selection text color is incorrect--it doesn't change.
This is intentional. The text color only needs to change when the color of the highlight effect is close enough to the original text color that it would make the text difficult to read. However the default highlight color is a very light blue, so there is no need to change the text color to preserve readability.
I am not using the default breeze color scheme, I'm using a modified version of Norway with a dark brown selection background and white selection text. This makes the black text color hard to read when something is selected.
> there is no need to change the text color
The Breeze color scheme is free to use the same text color for selections.
Only paired combinations of QPalette and KColorScheme are supported; reopening.
(In reply to Michael D from comment #2)
> I am not using the default breeze color scheme, I'm using a modified version
> of Norway with a dark brown selection background and white selection text.
> This makes the black text color hard to read when something is selected.
Can you attach a screenshot?
And for the Plasma theme, are you using Breeze, Breeze Dark, Breeze Light, or a different theme?
See also https://store.kde.org/p/1001640/
The folder view expanded representation looks fine with the CheckColorRoles color scheme (well, it looks the same as everything else in Plasma). I suspect a defective color scheme.
Michael, can you also attach the color scheme file so I can test with it?
Created attachment 124016 [details]
Using default Breeze plasma theme and a slightly modified version of Norway.
Created attachment 124017 [details]
Modified Norway color scheme
Created attachment 124018 [details]
How it looks for me
Thanks. I stand by my earlier conclusion that the folder view widget is doing the right thing: it takes the selection color and makes it mostly transparent to turn it into a light color, which allows the use of the standard text color rather than the selected text color.
When I use your modified Norway color scheme, it looks totally fine. See attachment.
I see from your attachment that this is not the way it looks for you. It looks like for you, the opacity effect for the selection highlight is not working, and instead the selection is 100% opaque.
Do you see the same problem in other plasma highlight effects that use a mostly-transparent center? For example, in KRunner or Kickoff. If so, there may be an issue with your graphics drivers or hardware, or a compositing issue in KWin.
You're not selecting the file in your screenshot, you're only hovering over it. Mine looks the same when I only hover. In krunner, selecting an item looks like hovering over it in folder view. So I think there's still something wrong with the selection text color when selecting an item in folder view.
Ah, you are entirely correct! I can confirm that. Will fix.
I've submitted a patch that should fix it: https://phabricator.kde.org/D25418
That's great, thanks!
Git commit a9291006771d92345dcb6ea93c035d9896c81f1d by Nate Graham.
Committed on 21/11/2019 at 21:01.
Pushed by ngraham into branch 'Plasma/5.17'.
[Folder view] Use selected text color for selected items in full representation
Right now, selected (not highlighted) items in the popup persist in using
the default text color , which can result in readability problems for light
themes that use a dark highlight effect.
Put a Folder widget in a horizontal panel, click it, hover the mouse over one
of the items in the list, and then click.
No change or regressions for selected items in Folder View on the desktop.
Reviewers: #vdg, #plasma, ndavis
Reviewed By: #vdg, ndavis
Subscribers: ndavis, plasma-devel
Differential Revision: https://phabricator.kde.org/D25418
M +9 -2 containments/desktop/package/contents/ui/FolderItemDelegate.qml