Bug 414271 - "Hamburger menu" doesn't have a text anymore?
Summary: "Hamburger menu" doesn't have a text anymore?
Status: RESOLVED INTENTIONAL
Alias: None
Product: dolphin
Classification: Applications
Component: general (show other bugs)
Version: 19.11.80
Platform: Arch Linux Linux
: NOR minor
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2019-11-18 18:38 UTC by Matej Mrenica
Modified: 2019-11-24 18:13 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matej Mrenica 2019-11-18 18:38:40 UTC
In previous versions there was a text bellow or next to the icon. Since 19.11.80
it's not there anymore. Switching text position modes doesn't do anything, text is always hidden.

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.17.3
KDE Frameworks Version: 5.64
Qt Version: 5.14.0
Comment 1 Nate Graham 2019-11-18 18:47:47 UTC
This is intentional. We did it to make it consistent with all the other hamburger menus, none of which have text. The old text was "Control" which is kind of a meaningless phrase anyway.
Comment 2 Matej Mrenica 2019-11-18 18:56:30 UTC
On one hand I understand, on the other, all icons except this one have a text so my toolbar looks a little weird.
Comment 3 Christoph Feck 2019-11-18 20:25:57 UTC
Removing text is also an accessibility issue (think screen readers). If 'Control' doesn't fit, how about 'Menu'?
Comment 4 Elvis Angelaccio 2019-11-18 20:43:33 UTC
(In reply to Christoph Feck from comment #3)
> Removing text is also an accessibility issue (think screen readers). If
> 'Control' doesn't fit, how about 'Menu'?

Isn't possible to add an hidden text used only for accessibility purposes?

If it's really an accessibility issue, it should be fixed everywhere we use hamburger menus, not just in dolphin.
Comment 5 Christoph Feck 2019-11-18 22:51:09 UTC
Yes, see https://doc.qt.io/qt-5/qwidget.html#accessibleName-prop
Comment 6 Elvis Angelaccio 2019-11-24 18:13:42 UTC
Git commit 82e366f024cb47106f0195e53f97c5beea2e798a by Elvis Angelaccio.
Committed on 24/11/2019 at 18:06.
Pushed by elvisangelaccio into branch 'release/19.12'.

Fix accessibility regression on the Dolphin Control button

9cd042a86c removed the text from the Control button without setting an
accessibleName property, which is a regression for screen-reader users.

This breaks the 19.12 string freeze, but since it's the same string we
were translating before 9cd042a86c, hopefully it's not going to be too
much of a burden for translators.
CCMAIL: kde-i18n-doc@kde.org

M  +1    -0    src/dolphinmainwindow.cpp

https://commits.kde.org/dolphin/82e366f024cb47106f0195e53f97c5beea2e798a