Bug 414201 - Modified command string for app is not saved
Summary: Modified command string for app is not saved
Status: RESOLVED NOT A BUG
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Menu (Kicker) (show other bugs)
Version: 5.17.3
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-16 11:38 UTC by postix
Modified: 2019-11-17 22:08 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshoft of the command edit panel. The GTK_USE_PORTAL=1 is not displayed again after saving and reopen the panel. (49.30 KB, image/png)
2019-11-16 11:38 UTC, postix
Details

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2019-11-16 11:38:54 UTC
Created attachment 123950 [details]
Screenshoft of the command edit panel. The GTK_USE_PORTAL=1 is not displayed again after saving and reopen the panel.

SUMMARY

After saving a modified command and reopen the command editor, the old command is displayed again.

STEPS TO REPRODUCE
1. Open Kicker
2. Right click on an app, choose "modify app"
3. Got to tab "app".
4. Modify the command, the eg append "GTK_USE_PORTAL=1"
5. Save it
6. Repeat steps 1 to 3

OBSERVED RESULT

GTK_USE_PORTAL=1 is missing after step 6

EXPECTED RESULT

GTK_USE_PORTAL=1 is saved and displayed

SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux 
KDE Plasma Version: 5.17.3
KDE Frameworks Version: 5.65.0
Qt Version: 5.13.2
Comment 1 postix 2019-11-16 11:52:16 UTC
Obviously it is saved as the command works and the GTK_USE_PORTAL=1 is respected, but the string won't be not displayed again in the app's panel.
Comment 2 David Edmundson 2019-11-16 22:25:05 UTC
Are you sure it's respected, it's not a valid Exec line as per:

https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-1.0.html#exec-variables


This should work though.

/bin/env FOO=1 /path/to/otherApp

if so, then there's not a bug other than us maybe needing some docs
Comment 3 postix 2019-11-16 23:06:43 UTC
(In reply to David Edmundson from comment #2)
> Are you sure it's respected, 
Yes I am, since whenever I changed between 0 and 1 the file dialog changed accordingly.

However, the complete string is now saved and I cannot reproduce it anymore. Weird.

> it's not a valid Exec line as per:
https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-1.0.html#exec-variables
> /bin/env FOO=1 /path/to/otherApp
> 
> if so, then there's not a bug other than us maybe needing some docs

Thanks, I will use the correct way from now on. Sorry for the inconvenience. :)
Comment 4 David Edmundson 2019-11-17 22:08:56 UTC
no problem