Bug 414180 - Items are constantly shrinking/expanding
Summary: Items are constantly shrinking/expanding
Status: RESOLVED FIXED
Alias: None
Product: lattedock
Classification: Plasma
Component: application (show other bugs)
Version: git (master)
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Michail Vourlakos
URL:
Keywords:
: 414676 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-11-15 15:25 UTC by Michail Vourlakos
Modified: 2019-12-01 17:20 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 0.9.5


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michail Vourlakos 2019-11-15 15:25:07 UTC
SUMMARY

when the Latte contents exceed the maximum length then there are cases that the automatic icon size algorithm breaks by constantly shrinking/expanding the items size until the user changes somehow the contents layout, e.g. by opening/closing an application.
Comment 1 flighter007 2019-11-15 18:44:29 UTC
Have been seeing this bug with Latte Dock for a long time, since version 0.8.x or perhaps even earlier, and still experiencing it on Latte Dock 0.9.4.
Comment 2 flighter007 2019-11-15 18:47:38 UTC
Adjusting the dock length temporarily fix the problem, but not permanently, it just makes the problem to occur at a different dock length.
Comment 3 Michail Vourlakos 2019-11-30 08:46:15 UTC
*** Bug 414676 has been marked as a duplicate of this bug. ***
Comment 4 Tristan Grimaux 2019-11-30 16:35:16 UTC
If the dock is placed vertically it's very easy to reproduce, and very annoying. I've filled a new bug because I couldn't find this one, but it's not RARE CASES when you have your taskbar at one of your monitor sides
Comment 5 Michail Vourlakos 2019-11-30 17:32:32 UTC
(In reply to Tristan Grimaux from comment #4)
> If the dock is placed vertically it's very easy to reproduce, and very
> annoying. I've filled a new bug because I couldn't find this one, but it's
> not RARE CASES when you have your taskbar at one of your monitor sides

Ok no problem, I rephrased it but I dont think this will help to reduce the time that a fix is going to land...
Comment 6 Michail Vourlakos 2019-12-01 17:20:15 UTC
Git commit 9739c43674fbf3b19b6a13584a7364998a49b0d5 by Michail Vourlakos.
Committed on 01/12/2019 at 17:17.
Pushed by mvourlakos into branch 'v0.9'.

introduce AutomaticItemSizer and add protector

--the automatic item sizer algorithm now is present
in its own class/responsibility area. As a new
improvement/fix the new implementation provides also
a protector/tracker that when the current prediction
to grow has already be applied two steps back in
history then the growing is not applied. This way
endless loops with growings and shrinks are blocked.
FIXED-IN:0.9.5

A  +234  -0    containment/package/contents/ui/AutomaticItemSizer.qml     [License: GPL (v2+)]
M  +1    -1    containment/package/contents/ui/DebugWindow.qml
M  +5    -5    containment/package/contents/ui/VisibilityManager.qml
M  +1    -1    containment/package/contents/ui/editmode/Visual.qml
M  +2    -2    containment/package/contents/ui/layouts/LayoutsContainer.qml
M  +6    -140  containment/package/contents/ui/main.qml

https://commits.kde.org/latte-dock/9739c43674fbf3b19b6a13584a7364998a49b0d5
Comment 7 Michail Vourlakos 2019-12-01 17:20:52 UTC
Git commit 747d4870a0c82e2afe41bfe5ed7ecfa61165b6e1 by Michail Vourlakos.
Committed on 01/12/2019 at 17:20.
Pushed by mvourlakos into branch 'master'.

introduce AutomaticItemSizer and add protector

--the automatic item sizer algorithm now is present
in its own class/responsibility area. As a new
improvement/fix the new implementation provides also
a protector/tracker that when the current prediction
to grow has already be applied two steps back in
history then the growing is not applied. This way
endless loops with growings and shrinks are blocked.
FIXED-IN:0.9.5

A  +234  -0    containment/package/contents/ui/AutomaticItemSizer.qml     [License: GPL (v2+)]
M  +1    -1    containment/package/contents/ui/DebugWindow.qml
M  +5    -5    containment/package/contents/ui/VisibilityManager.qml
M  +1    -1    containment/package/contents/ui/editmode/Visual.qml
M  +2    -2    containment/package/contents/ui/layouts/LayoutsContainer.qml
M  +6    -140  containment/package/contents/ui/main.qml

https://commits.kde.org/latte-dock/747d4870a0c82e2afe41bfe5ed7ecfa61165b6e1