Bug 414098 - Radiobutton falsely unchecked for "custom position for notifications"
Summary: Radiobutton falsely unchecked for "custom position for notifications"
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Notifications (show other bugs)
Version: 5.17.2
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Kai Uwe Broulik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-13 15:09 UTC by postix
Modified: 2020-01-15 09:13 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.18.0


Attachments
Video of the issue. (193.68 KB, video/mp4)
2019-11-13 15:09 UTC, postix
Details
Video of the issue. (209.23 KB, video/mp4)
2019-11-13 15:11 UTC, postix
Details

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2019-11-13 15:09:24 UTC
Created attachment 123890 [details]
Video of the issue.

SUMMARY

If a custom position was chosen and the user clicks on "Notifactions" in the bread crumb, the former option "next to the notification symbol" is still checked instead of "user defined position". See video

STEPS TO REPRODUCE
See video


SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux 
KDE Plasma Version: 5.17.2
KDE Frameworks Version: 5.65.0
Qt Version: 5.13.2
Comment 1 postix 2019-11-13 15:11:53 UTC
Created attachment 123891 [details]
Video of the issue.
Comment 2 Kai Uwe Broulik 2020-01-15 09:13:34 UTC
Git commit db95a53cbdb60a5bab2ac65931938684d09cc140 by Kai Uwe Broulik.
Committed on 15/01/2020 at 09:12.
Pushed by broulik into branch 'master'.

[Notifications KCM] Force re-evaluation of position radio buttons

The Settings object is kind of a write-only state and doesn't signal property changes unless "live" (where it would listen to other
settings changing which we don't want inside the KCM) or only upon save().
This is arguably a questionable design decision on my side :-) but usually it's not a problem as the KCM controls will have
whatever state the user will put them in but it falls apart in case we switch to another page and back without saving.
FIXED-IN: 5.18.0

Differential Revision: https://phabricator.kde.org/D26162

M  +3    -0    kcms/notifications/package/contents/ui/main.qml

https://commits.kde.org/plasma-desktop/db95a53cbdb60a5bab2ac65931938684d09cc140