Bug 414071 - Hide background when not needed always hides background
Summary: Hide background when not needed always hides background
Status: RESOLVED FIXED
Alias: None
Product: lattedock
Classification: Plasma
Component: application (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Michail Vourlakos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-12 17:06 UTC by adrien.brunelat
Modified: 2019-11-13 19:45 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 0.9.5
Sentry Crash Report:


Attachments
The Latte layout file (8.33 KB, text/plain)
2019-11-13 09:38 UTC, adrien.brunelat
Details
Transparent panel (21.15 KB, image/png)
2019-11-13 18:35 UTC, adrien.brunelat
Details

Note You need to log in before you can comment on or make changes to this bug.
Description adrien.brunelat 2019-11-12 17:06:50 UTC
SUMMARY

Hide background when not needed always makes background 0% opacity

STEPS TO REPRODUCE
1. Install Latte dock
2. Tick the option "hide background when not needed"
3. maximize an application like Firefox

OBSERVED RESULT

The background stays hidden, which is problematic for panels.


EXPECTED RESULT

The background should appear as configured in the settings


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Manjaro
(available in About System)
KDE Plasma Version: 5.17.2
KDE Frameworks Version: 5.63.0
Qt Version: 5.13.1
Comment 1 adrien.brunelat 2019-11-12 17:10:11 UTC
"Prefer opaque BG when touching any window" should be disabled also.

I'd like settings to be applied, with background transparency and blur instead of opaque BG.
Comment 2 Michail Vourlakos 2019-11-12 18:45:17 UTC
1. Which Latte version are you using?
2. Send me your latte layout file to test it
Comment 3 adrien.brunelat 2019-11-13 09:38:27 UTC
Created attachment 123885 [details]
The Latte layout file
Comment 4 adrien.brunelat 2019-11-13 09:38:50 UTC
Latte Dock version: 0.9.4-1
Comment 5 adrien.brunelat 2019-11-13 09:40:28 UTC
Also the "add background when not needed" does not show the background when the text from the panel and desktop bg are roughly the same color (white on white).
Comment 6 Michail Vourlakos 2019-11-13 11:19:01 UTC
> The background should appear as configured in the settings

you have not enabled any such option, The option


> Also the "add background when not needed" does not show the background when
> the text from the panel and desktop bg are roughly the same color (white on
> white).

dont mess issues, open a different one if it is irrelevant...

you need to describe exactly what you are trying and you can provide also screenshots to describe it better...

1. How it should look with clean desktop and how it look now...
2. How it should look when a window is maximized and how it looks now...
3. etc...
Comment 7 Michail Vourlakos 2019-11-13 11:24:09 UTC
If you enable Colors -> From Window -> Touching does it work as you would like it to work, if not what breaks?
Comment 8 Michail Vourlakos 2019-11-13 11:50:49 UTC
Git commit 556ecae3e2067c2ec7ef6ccbaff6c26c04fe0a67 by Michail Vourlakos.
Committed on 13/11/2019 at 11:50.
Pushed by mvourlakos into branch 'v0.9'.

improve option "Hide Background when not needed"

--when option "Hide Background when not needed" is
used on its own activates or not the forceTransparentPanel
code path. So when that option is enabled and any
window is touching the Latte::View then the force
transparency codepath should be disabled. In such
case the user background settings are applied.
FIXED-IN:0.9.5

M  +1    -1    containment/package/contents/ui/main.qml
M  +1    -1    shell/package/contents/configuration/pages/AppearanceConfig.qml

https://commits.kde.org/latte-dock/556ecae3e2067c2ec7ef6ccbaff6c26c04fe0a67
Comment 9 Michail Vourlakos 2019-11-13 11:51:18 UTC
Git commit 63ed290593b45b8560536c9ccdc8e30542ca93d5 by Michail Vourlakos.
Committed on 13/11/2019 at 11:51.
Pushed by mvourlakos into branch 'master'.

improve option "Hide Background when not needed"

--when option "Hide Background when not needed" is
used on its own activates or not the forceTransparentPanel
code path. So when that option is enabled and any
window is touching the Latte::View then the force
transparency codepath should be disabled. In such
case the user background settings are applied.
FIXED-IN:0.9.5

M  +1    -1    containment/package/contents/ui/main.qml
M  +1    -1    shell/package/contents/configuration/pages/AppearanceConfig.qml

https://commits.kde.org/latte-dock/63ed290593b45b8560536c9ccdc8e30542ca93d5
Comment 10 adrien.brunelat 2019-11-13 18:35:13 UTC
Created attachment 123900 [details]
Transparent panel

Well the panel stays fully transparent even though a background is clearly needed here. Maybe I misunderstood the "when background not needed" part of the option?

I'll try the 9.5 version to see if your commits fixed that issue.
Comment 11 adrien.brunelat 2019-11-13 19:43:44 UTC
Just noticed that this doesn't occur when panel set to "always visible". Happens with "dodge maximized".
Comment 12 Michail Vourlakos 2019-11-13 19:45:10 UTC
feel free to test the fix commit or wait for 0.9.5 to reopen if it isnt solved for you.