Bug 414060 - label of button contains "(i18n_argument_missing)"
Summary: label of button contains "(i18n_argument_missing)"
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: kcm_lookandfeel (show other bugs)
Version: 5.17.2
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-12 10:45 UTC by Patrick Silva
Modified: 2019-11-15 15:42 UTC (History)
2 users (show)

See Also:
Latest Commit: https://commits.kde.org/knewstuff/0099d090be51b2532dda3b61ad1d9e4e3caabcd1
Version Fixed In:
Sentry Crash Report:

Attachments
screenshot (84.96 KB, image/png)
2019-11-12 10:45 UTC, Patrick Silva 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2019-11-12 10:45:15 UTC 
STEPS TO REPRODUCE
1. open system settings > global theme
2. 
3. 

OBSERVED RESULT
As we can see in the attached screenshot, the label of the button on bottom contains "(i18n_argument_missing)"

EXPECTED RESULT
label of the button is "Download New Global Themes"

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.17.80
KDE Frameworks Version: 5.65.0
Qt Version: 5.13.1
Comment 1 Patrick Silva 2019-11-12 10:45:48 UTC 
Created attachment 123858 [details]
screenshot
Comment 2 David Edmundson 2019-11-12 11:58:47 UTC 
FWIW, that only appears on dev builds. Fixed anyway

https://phabricator.kde.org/D25270
Comment 3 David Edmundson 2019-11-15 15:42:39 UTC 
Git commit 0099d090be51b2532dda3b61ad1d9e4e3caabcd1 by David Edmundson.
Committed on 15/11/2019 at 15:42.
Pushed by davidedmundson into branch 'master'.

Correctly set i18n arguments in one pass

Summary:
i18n("asdf %1") will expand and fail as it has no arguments, leading to
a warning.

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D25270

M  +1    -1    src/qtquick/qml/Button.qml

https://commits.kde.org/knewstuff/0099d090be51b2532dda3b61ad1d9e4e3caabcd1