Bug 413980 - "Defaults" button should restore system wide defaults
Summary: "Defaults" button should restore system wide defaults
Status: RESOLVED LATER
Alias: None
Product: frameworks-kconfigwidgets
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: kdelibs bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-09 15:19 UTC by Björn Feber
Modified: 2019-11-13 16:30 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Feber 2019-11-09 15:19:03 UTC
SUMMARY
When you have system wide defaults set in for example /etc/xdg and clicking the "Defaults" button in KCMs, instead of using the system wide defaults it resets everything to hardcoded Plasma values.

STEPS TO REPRODUCE
1. Have defaults set for example for the icon theme in /etc/xdg/kdeglobals
2. Click the defaults button of the respective KCM

OBSERVED RESULT
It resets everything to hardcoded Plasma values (e.g. Breeze).

EXPECTED RESULT
It uses the system wide defaults.
Comment 1 David Edmundson 2019-11-12 18:54:03 UTC
There isn't one magic fix for this, every KCM needs fixing.

It's a side effect of the kcfg porting work you've probably seen in systemsettings.

If you run e.g lookandfeel (master) with your experiment it works correctly.
Icons is in the queue, I think in review currently?

Please confirm with look and feel, if so it's probably best to close this as resolved-later and re test when all the theming modules are done.
Comment 2 Björn Feber 2019-11-12 18:59:06 UTC
(In reply to David Edmundson from comment #1)
> There isn't one magic fix for this, every KCM needs fixing.
> 
> It's a side effect of the kcfg porting work you've probably seen in
> systemsettings.
> 
> If you run e.g lookandfeel (master) with your experiment it works correctly.
> Icons is in the queue, I think in review currently?
> 
> Please confirm with look and feel, if so it's probably best to close this as
> resolved-later and re test when all the theming modules are done.

Huh, when you set a different look and feel theme and testart the KCM the button doesn't seem to do anything anymore.
Comment 3 Björn Feber 2019-11-12 18:59:25 UTC
*restart
Comment 4 Kevin Ottens 2019-11-13 09:27:45 UTC
Currently 100% done (with all patches merged): desktoptheme and ksplash. There are more which are basically done but in various stages of review, and even more in the works.