Bug 413745 - Add shortcuts for left / right page rotation
Summary: Add shortcuts for left / right page rotation
Status: CONFIRMED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 1.8.2
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-02 14:42 UTC by postix
Modified: 2019-11-10 21:30 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Shortcuts for AltGr+L/R (29.00 KB, image/png)
2019-11-02 15:06 UTC, postix
Details

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2019-11-02 14:42:18 UTC
SUMMARY

Currently one has go into the menu to change the page rotation.
Comment 1 Yuri Chornoivan 2019-11-02 14:47:59 UTC
Any proposals on what these shortcuts could be?

Thanks in advance for your answer.
Comment 2 postix 2019-11-02 14:51:32 UTC
> Any proposals on what these shortcuts could be?

I thought about Alt+L/R and Alt+Shift+L/R for a single page (#413746).
Those are not used currently and seem intuitive to me.
Comment 3 postix 2019-11-02 14:53:02 UTC
I see Alt+ is used for the shortcuts of the menu entries. Maybe AltGr then?
Comment 4 Yuri Chornoivan 2019-11-02 14:57:42 UTC
Alt+Shift+Left/Right is for "Previous/Next page" now. Alt++Left/Right can be assigned via the shortcuts dialog.

So this bug is a JJ to prescribe the default shortcuts.
Comment 5 postix 2019-11-02 15:06:16 UTC
Created attachment 123663 [details]
Shortcuts for AltGr+L/R

Yes, you are right, it's basically a question assign default shortcuts for those actions.

If set to AltGr+L the shortcut representation becomes ł and and for AltGr+R it becomes ¶. 
This is really hard for a user to figure out, what needs to be pressed.

Is it possible to instead display AltGr+L and AltGr+R? Or is it complicated due to different keyboard layouts?
Comment 6 Yuri Chornoivan 2019-11-02 16:18:34 UTC
https://invent.kde.org/kde/okular/merge_requests/60
Comment 7 Laura David Hurka 2019-11-02 18:19:25 UTC
Sorry, Falkon does not load the gitlab MR. To answer Postix’ question:

> If set to AltGr+L the shortcut representation becomes ł and and for AltGr+R it becomes ¶. 
> This is really hard for a user to figure out, what needs to be pressed.

> Is it possible to instead display AltGr+L and AltGr+R? Or is it complicated due to different keyboard layouts?

This will probably not be possible. There are keyboard layouts without AltGr. Qt does not know this key as modifier. And besides that, AltGr is a very uncommon modifier.

At least, Qt (since Qt5) does not care on which keyboard layer a shortcut key is pressed. For Neo2, 1 is the same as Mod4+M.

https://doc.qt.io/qt-5/qt.html#KeyboardModifier-enum
Comment 8 Nate Graham 2019-11-04 18:34:27 UTC
The obvious solution is to use the standard shortcuts defined in kstandardshortcuts.

However the bigger problem is that this feature doesn't generally do what people expect: it rotates every page rather than the current page, which is not super useful. I think before we do this, we need to fix/implement Bug 413746.
Comment 9 Albert Astals Cid 2019-11-10 01:19:29 UTC
Why would it just rotate the current page?

That makes no sense, are you telling me that people have documents where each of the pages is independently wrongly rotated? I've never came across such a document myself.
Comment 10 Albert Astals Cid 2019-11-10 01:20:02 UTC
BTW i don't think the rotation actions are used so often that need default shortcuts, people that use them can add one themselves.
Comment 11 Laura David Hurka 2019-11-10 03:17:30 UTC
(In reply to Albert Astals Cid from comment #9)
> Why would it just rotate the current page?
> 
> That makes no sense, are you telling me that people have documents where
> each of the pages is independently wrongly rotated? I've never came across
> such a document myself.

This happens:
http://ww1.microchip.com/downloads/en/DeviceDoc/00001792E.pdf
Pages 64 and 65.

So mark this as duplicate of Bug 307224?
Comment 12 Albert Astals Cid 2019-11-10 11:23:21 UTC
I don't think those are duplicates no, one is about single page rotation and the other about shortcuts for the rotation action.