Bug 413702 - Weather Report widget should not create empty space in Plasma panel when weather information is not available and the option to show temperature beside the widget icon is enabled
Summary: Weather Report widget should not create empty space in Plasma panel when weat...
Status: RESOLVED FIXED
Alias: None
Product: kdeplasma-addons
Classification: Plasma
Component: Weather (show other bugs)
Version: unspecified
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-01 11:14 UTC by Patrick Silva
Modified: 2019-11-04 19:03 UTC (History)
1 user (show)

See Also:
Latest Commit: https://commits.kde.org/kdeplasma-addons/ddac86d815a05a334f3bfab6f3ab7b7c77db5ae8
Version Fixed In: 5.17.3
Sentry Crash Report:

Attachments
screenshot (13.72 KB, image/png)
2019-11-01 11:14 UTC, Patrick Silva 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2019-11-01 11:14:21 UTC 
Created attachment 123642 [details]
screenshot

STEPS TO REPRODUCE
1. add weather report widget to Plasma panel
2. open widget settings, set your location and click on "Apply" button
3. click on "Appearance" section, check the option to show the temperature
beside the widget icon
4. disconnect your internet
5. click on "Ok" button

OBSERVED RESULT
empty space beside the widget icon. See the attached screenshot.

EXPECTED RESULT
widget report widget never creates empty space in Plasma panel when weather
information is not available

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.17.80
KDE Frameworks Version: 5.64.0
Qt Version: 5.13.1
Comment 1 Nate Graham 2019-11-04 15:04:12 UTC 
Bleh. Will fix.
Comment 2 Nate Graham 2019-11-04 19:03:42 UTC 
Git commit ddac86d815a05a334f3bfab6f3ab7b7c77db5ae8 by Nate Graham.
Committed on 04/11/2019 at 19:02.
Pushed by ngraham into branch 'Plasma/5.17'.

[applets/weather] Don't show temp label in panel when it's blank
Otherwise there's a big ugly gap in a horizontal panel while it's
first loading
FIXED-IN: 5.17.3

M  +3    -0    applets/weather/package/contents/ui/IconAndTextItem.qml

https://commits.kde.org/kdeplasma-addons/ddac86d815a05a334f3bfab6f3ab7b7c77db5ae8