Bug 413701 - digikam 6.3.0 does not build against current plasma
Summary: digikam 6.3.0 does not build against current plasma
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Portability-Runtime (show other bugs)
Version: 6.3.0
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-01 10:56 UTC by Mathias Homann
Modified: 2019-11-02 16:07 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 7.0.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mathias Homann 2019-11-01 10:56:51 UTC
SUMMARY

Trying to build digikam 6.3.0 on OBS against the current KDE Plasma / KDE Applications libraries, linker fails with this error:

[  780s] [ 95%] Built target Generic_Panorama_Plugin
[  782s] /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: /usr/lib64/libKF5AkonadiContact.so.5: undefined reference to `KContacts::AddresseeList::AddresseeList()'
[  782s] /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: /usr/lib64/libKF5AkonadiContact.so.5: undefined reference to `KContacts::ContactGroup::contactReference(unsigned int)'
[  782s] /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: /usr/lib64/libKF5AkonadiContact.so.5: undefined reference to `KContacts::AddresseeList::~AddresseeList()'
[  782s] /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: /usr/lib64/libKF5AkonadiContact.so.5: undefined reference to `KContacts::ContactGroup::data(unsigned int)'
[  782s] /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: /usr/lib64/libKF5AkonadiContact.so.5: undefined reference to `KContacts::AddresseeList::operator=(KContacts::AddresseeList const&)'
[  782s] /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: /usr/lib64/libKF5AkonadiContact.so.5: undefined reference to `KContacts::ContactGroup::data(unsigned int) const'
[  782s] /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: /usr/lib64/libKF5AkonadiContact.so.5: undefined reference to `KContacts::AddresseeList::AddresseeList(KContacts::AddresseeList const&)'
[  782s] collect2: error: ld returned 1 exit status

STEPS TO REPRODUCE
1. clone digikam from KDE:Extra into your own project
2. add KDE:Frameworks5 to your build configuration
3. wait

OBSERVED RESULT
Build fails

EXPECTED RESULT
Build should not fail
Comment 1 caulier.gilles 2019-11-01 11:12:11 UTC
Do you need really to enable Akonady Contact support in digiKam ? We don't well check this dependency since a while...

Gilles Caulier
Comment 2 Mathias Homann 2019-11-01 11:23:36 UTC
no, i don't actually **need** it but that's how the original package in KDE:Extra on OBS is being built... what does that even do?
Comment 3 caulier.gilles 2019-11-01 11:33:40 UTC
The Akonadi contact option is disabled by default. Just turn off in configuration rules passed to cmake :

https://www.digikam.org/api/index.html#cmakeoptions

Gilles Caulier
Comment 4 Maik Qualmann 2019-11-01 18:04:57 UTC
I use Akonadi contact with current plasma desktop. It compiles without problems and works flawlessly.

Maik
Comment 5 Maik Qualmann 2019-11-01 19:21:06 UTC
Git commit c8ae669cad36eaad7920fd729df2dc74119ea5ff by Maik Qualmann.
Committed on 01/11/2019 at 19:20.
Pushed by mqualmann into branch 'master'.

add dependency of KContacts
FIXED-IN: 7.0.0

M  +2    -1    NEWS
M  +1    -0    core/CMakeLists.txt
M  +1    -1    core/utilities/extrasupport/addressbook/CMakeLists.txt

https://invent.kde.org/kde/digikam/commit/c8ae669cad36eaad7920fd729df2dc74119ea5ff
Comment 6 Mathias Homann 2019-11-01 20:35:12 UTC
...there's a digikam 7.0 in the works? I gotta try that!
Comment 7 caulier.gilles 2019-11-01 21:43:09 UTC
yes, in beta stage for the moment :

https://files.kde.org/digikam/

Gilles Caulier
Comment 8 Mathias Homann 2019-11-02 10:53:52 UTC
(In reply to Maik Qualmann from comment #5)
> Git commit c8ae669cad36eaad7920fd729df2dc74119ea5ff by Maik Qualmann.
> Committed on 01/11/2019 at 19:20.
> Pushed by mqualmann into branch 'master'.
> 
> add dependency of KContacts
> FIXED-IN: 7.0.0
> 
> M  +2    -1    NEWS
> M  +1    -0    core/CMakeLists.txt
> M  +1    -1    core/utilities/extrasupport/addressbook/CMakeLists.txt
> 
> https://invent.kde.org/kde/digikam/commit/
> c8ae669cad36eaad7920fd729df2dc74119ea5ff

I'm still getting the same linker errors if I apply those changes to the 6.3 sources, though...
Comment 9 Mathias Homann 2019-11-02 11:14:30 UTC
and the 6.4 version that I see tagged on the kde git is not an official release (yet), right?
Comment 10 caulier.gilles 2019-11-02 11:38:50 UTC
6.4.0 tarball and bundles are currently under transfert to KDE server. Official announcement is not yet done. Please wait...

Gilles Caulier
Comment 11 caulier.gilles 2019-11-02 11:39:45 UTC
If you apply the linking patch from Maik, remember to clear Cmake cache in build directory...

Gilles Caulier
Comment 12 caulier.gilles 2019-11-02 11:41:52 UTC
Maik,

Do you think that we need to create a 6.5.0 branch in git to only apply small patches in goal to release 6.5.0 before 7.0.0 final planned in February/March 2020 ?

Gilles
Comment 13 Mathias Homann 2019-11-02 13:14:20 UTC
(In reply to caulier.gilles from comment #11)
> If you apply the linking patch from Maik, remember to clear Cmake cache in
> build directory...
even on a fresh, clean build directory created from unpacking the source tarball?

ok ... i have no idea how to do that o.0
Comment 14 caulier.gilles 2019-11-02 13:17:39 UTC
yes re-build from scratch.

Gilles Caulier
Comment 15 Mathias Homann 2019-11-02 14:53:30 UTC
(In reply to caulier.gilles from comment #14)
> yes re-build from scratch.


I'm trying to build a rpm package, that process is *always* "from scratch"....
Comment 16 Maik Qualmann 2019-11-02 16:01:07 UTC
Git commit eb362bdb35427c60b424e339911a93dc6bd0768d by Maik Qualmann.
Committed on 02/11/2019 at 15:59.
Pushed by mqualmann into branch 'master'.

check if KContacts was found

M  +1    -1    core/CMakeLists.txt

https://invent.kde.org/kde/digikam/commit/eb362bdb35427c60b424e339911a93dc6bd0768d
Comment 17 Maik Qualmann 2019-11-02 16:07:47 UTC
(In reply to caulier.gilles from comment #12)
> Maik,
> 
> Do you think that we need to create a 6.5.0 branch in git to only apply
> small patches in goal to release 6.5.0 before 7.0.0 final planned in
> February/March 2020 ?
> 
> Gilles

There is certainly one thing that would be good for 6.5.0 (the memory hole in the image editor). But I think the 7.0.0 is already running very well and we should release a Beta1 early.

Maik