Bug 413695 - bug in review bar, custom tool, text comment color gets reverted
Summary: bug in review bar, custom tool, text comment color gets reverted
Status: REPORTED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 1.6.3
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-11-01 06:49 UTC by severin.kunz
Modified: 2019-11-06 19:48 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description severin.kunz 2019-11-01 06:49:05 UTC
I have customized the tools on the review bar and changed the color of the text comment to blue. And I also added a new text comment tool with the color red. This has worked great, until I have restarted the program. Now both tools show the right color in the icon, but both tools produce black text.

SOFTWARE/OS VERSIONS
Linux: Kubuntu 19.04
(available in AboutSystem)
KDE Plasma Version: 5.15.4
KDE Frameworks Version: 5.56.0
Qt Version: 5.12.2
Comment 1 severin.kunz 2019-11-01 07:54:44 UTC
Update: I just noticed that the appropriate color will be displayed when I move the textfield.
Comment 2 Nate Graham 2019-11-04 15:04:55 UTC
Simone, will this be fixed by your rewrite of the annotation tools?
Comment 3 Simone Gaiarin 2019-11-05 06:24:18 UTC
I cannot reproduce it in the current okular version (1.8.2).

Just to be clear, with 'text comment' you mean 'Typewriter', right?

Can you:
- post the result of `grep Annotation ~/.config/okularpartrc` when the problem occurs
- create a text annotation (it is displayed black), right click on it > Properties and check what color is displayed there (if the correct one blue/red or black)
- try to backup and delete `~/.config/okularpartrc` and try to reproduce the bug
Comment 4 Nate Graham 2019-11-05 15:11:43 UTC
FWIW I can't reproduce either.
Comment 5 Oliver Sander 2019-11-05 15:21:26 UTC
Actually, I can reproduce it.

> Just to be clear, with 'text comment' you mean 'Typewriter', right?

Yes

> Can you:
> - post the result of `grep Annotation ~/.config/okularpartrc` when the problem occurs

AnnotationTools=<tool id="1" type="note-linked"><engine color="#ffffff00" type="PickPoint" hoverIcon="tool-note"><annotation icon="Note" color="#ffffff00" type="Text"/></engine><shortcut>1</shortcut></tool>,<tool id="2" type="note-inline"><engine block="true" color="#ffffff00" type="PickPoint" hoverIcon="tool-note-inline"><annotation width="1" font="Noto Sans\\,8\\,-1\\,5\\,50\\,0\\,0\\,0\\,0\\,0\\,Regular" color="#ffffff00" type="FreeText"/></engine><shortcut>2</shortcut></tool>,<tool id="3" type="ink"><engine color="#ffff0000" type="SmoothLine"><annotation width="1" color="#ffff0000" type="Ink"/></engine><shortcut>3</shortcut></tool>,<tool id="4" type="highlight"><engine color="#ffffff00" type="TextSelector"><annotation color="#ffffff00" type="Highlight"/></engine><shortcut>4</shortcut></tool>,<tool id="5" type="straight-line"><engine points="2" color="#ffff5500" type="PolyLine"><annotation startStyle="5" width="1" endStyle="1" color="#ffff5500" type="Line" leadFwd="10" leadBack="10"/></engine><shortcut>5</shortcut></tool>,<tool id="6" type="polygon"><engine points="-1" color="#ff007eee" type="PolyLine"><annotation width="1" color="#ff007eee" type="Line"/></engine><shortcut>6</shortcut></tool>,<tool id="7" type="stamp"><engine block="true" type="PickPoint" hoverIcon="okular" size="64"><annotation icon="okular" type="Stamp"/></engine><shortcut>7</shortcut></tool>,<tool id="8" type="underline"><engine color="#ff000000" type="TextSelector"><annotation color="#ff000000" type="Underline"/></engine><shortcut>8</shortcut></tool>,<tool id="9" type="ellipse"><engine block="true" color="#ff00ffff" type="PickPoint"><annotation width="5" color="#ff00ffff" type="GeomCircle"/></engine><shortcut>9</shortcut></tool>,<tool id="10" type="typewriter"><engine block="true" type="PickPoint"><annotation textColor="#0000ff" width="0" color="#00ffffff" type="Typewriter"/></engine></tool>


> - create a text annotation (it is displayed black), right click on it > Properties and check what color is displayed there (if the correct one blue/red or black)

blue

> - try to backup and delete `~/.config/okularpartrc` and try to reproduce the bug

The problem persists.
Comment 6 Simone Gaiarin 2019-11-06 19:48:02 UTC
The settings look correct. The fact that when the annotation is moved the color is set to the correct one suggests that it is something related to how the annotation is rendered.

The new annotation toolbar is not going to fix this.