Created attachment 123632 [details] Screenshot: Left current version, right proposal SUMMARY Currently by default there's a bottom panel only showing the page number. This panel takes relatively much vertical space and besides the page number, does not have much functionality. Therefore I suggest to move the page number to the top panel to hide the bottom panel by default.
If you do that you need to find a new place to show the page size when not all page sizes are the same.
This is something I've toyed with as well but also ran into the issue Albert describes. Another issue us that this would increase the width of the toolbar's toolbar button row, making it more likely that items will be pushed into the overflow menu when the window is not maximized, which is somewhat user-unfriendly. If we do this, we'd also probably need to adjust the current set of toolbar items. Worth thinking about. Postix, can you make some proposals for the above matters?
> show the page size when not all page sizes are the same Can you please explain what you mean by "page size"? Besides the number of pages, I haven't seen any other information in the status bar. > Another issue us that this would increase the width of the toolbar's toolbar button row, > making it more likely that items will be pushed into the overflow menu > when the window is not maximized, which is somewhat user-unfriendly. There are at least two buttons now, which are redundant: "Previous page and next page" on the top left of the bar as those two buttons are also found on each side of the "page number" tool in form of up- and down arrows.
Created attachment 123722 [details] Multiple size display When you have PDF consisting of pages with more than one size, the status bar also shows you the size of the current page on it. See the attachment. However, I wonder if this is worth keeping the status bar over. I had to artificially create a PDF with different page sizes just to see this feature in action as I didn't have any among the 878 PDFs on my machine. If we do as you request, people who miss seeing the page sizes for multi-page-size document can always re-enable the status bar.
(In reply to Postix from comment #3) > There are at least two buttons now, which are redundant: "Previous page and > next page" on the top left of the bar as those two buttons are also found on > each side of the "page number" tool in form of up- and down arrows. Maybe that’s a bug. We decided to change the left and right arrows in the page bar to up and down arrow, because we found it to be better (e. g. independent of layout direction, try to launch okular -reverse). But we didn’t change the arrows of the toolbar buttons (wich are already correct for reverse layout). In my opinion, the Previous and Next buttons in the toolbar can be removed, because they are less intuitive than the page bar, because there is no page number near the buttons.
Yeah right now there's redundancy in that there are two sets of next/previous buttons. I guess the question is whether this should be fixed by removing the toolbar buttons and keeping the status bar, or putting the navigation controls from the status bar into the toolbar and hiding the status bar. The latter option makes more sense to me IMO.
(In reply to Nate Graham from comment #6) > Yeah right now there's redundancy in that there are two sets of > next/previous buttons. I guess the question is whether this should be fixed > by removing the toolbar buttons and keeping the status bar, or putting the > navigation controls from the status bar into the toolbar and hiding the > status bar. > > The latter option makes more sense to me IMO. In the latter option, we also should remove the toolbar buttons, because the toolbar widget of the page bar already has these buttons. Concerning the page size: Would it make sense to put page-related information directly into the grey background of PageView? The page number itself could also be shown there, so it is obvious which page is which. I would also like annotation comment windows sticked to the grey background, instead of floating on the view. Currently you have to close all comment windows manually when you scroll to another page.
(In reply to David Hurka from comment #7) > In the latter option, we also should remove the toolbar buttons, because the > toolbar widget of the page bar already has these buttons. Yes, I've submitted an MR that does just this: https://invent.kde.org/kde/okular/merge_requests/61 > Concerning the page size: Would it make sense to put page-related > information directly into the grey background of PageView? The page number > itself could also be shown there, so it is obvious which page is which. Hmm, that might be a bit weird. In general I don't like when pop-ups or messages permanently cover content. > I would also like annotation comment windows sticked to the grey background, > instead of floating on the view. Currently you have to close all comment > windows manually when you scroll to another page. Unrelated to this issue. :)
Git commit 5b25ed3356542e73c2751df40d803cd332ec83f1 by Nate Graham. Committed on 03/06/2020 at 03:45. Pushed by ngraham into branch 'master'. Hide status bar by default and move navigation controls into toolbar FIXED-IN: 1.9.0 M +1 -1 conf/okular.kcfg M +7 -6 part.rc https://invent.kde.org/graphics/okular/commit/5b25ed3356542e73c2751df40d803cd332ec83f1
This change doesn't work well with us who use vertical panels, because it increases its width hugely, which is really ugly and takes up a lot of empty space. This has forced me to move the panel to the top, which takes up more vertical space than the original navigation controls in the bottom did. So, if the goal was to save vertical space, this has been counterproductive for me (apart from messing with my workflow). Is there any way to make the new navigation controls fit better in a vertical bar? If not, can we please add an option to return to the previous layout?
Created attachment 131239 [details] Screenshot: Vertical Toolbar with Navigation (In reply to David de Cos from comment #10) > This change doesn't work well with us who use vertical panels, because it > increases its width hugely, which is really ugly and takes up a lot of empty > space. > This does indeed not look good. Maybe there should be some detection to use the old behaviour for the vertical panels or the controls should become redesigned to better fit vertical panels IMO.
^ > redesigned to better fit vertical panels IMO. I.e. two different designs, one for a vertical and one for horizontal layout, if that's possible.
You can go to Settings -> [_] Show Page Bar and Settings -> Configure Toolbars..., then you have the old layout. For vertical toolbars, allowing to rotate widget actions would make sense, right? If someone wants a vertical toolbar, they probably want vertical text? I don’t know how that could be implemented in Qt.
(In reply to David Hurka from comment #13) > You can go to Settings -> [_] Show Page Bar and Settings -> Configure > Toolbars..., then you have the old layout. Thanks! I hadn't noticed that option was present in the main menu.