Bug 413659 - Option "Open folders during drag operations" has no effect on folders panel
Summary: Option "Open folders during drag operations" has no effect on folders panel
Status: REPORTED
Alias: None
Product: dolphin
Classification: Applications
Component: panels: folders (show other bugs)
Version: 19.04.3
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: Dolphin Bug Assignee
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-31 10:55 UTC by Werner Lehmann
Modified: 2023-02-05 13:47 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Werner Lehmann 2019-10-31 10:55:03 UTC
During drag operation into the folders pane the folders always expand automatically even though option "Open folders during drag operations" is off.


STEPS TO REPRODUCE
1. Switch off optio "Open folders during drag operations"
2. Drag a file into a folder on the folder pane.

OBSERVED RESULT
If folder has subfolders, it is expanded automatically.

EXPECTED RESULT
Drag target folder not expanded while option "Open folders during drag operations" is off.


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Kubuntu 19.10 with Plasma backports
KDE Plasma Version: 5.17.2
KDE Frameworks Version: 5.62.0
Qt Version: 5.12.4

ADDITIONAL INFORMATION
It appears as if the option is used only during drags inside of the details view mode with expandable folders. In this case it would be more logical to make this a suboption of this view mode. Currently the option is located in the "navigation" area of the preferences dialog. However, I would much prefer to have it working with the folders panel, too.
Comment 1 Maxim 2020-01-04 11:56:58 UTC
I can't repeat it.

Operating System: KDE neon 5.17
KDE Plasma Version: 5.17.4
KDE Frameworks Version: 5.65.0
Qt Version: 5.13.2
Kernel Version: 5.0.0-37-generic
OS Type: 64-bit
Processors: 8 × Intel® Core™ i7-6700HQ CPU @ 2.60GHz
Memory: 11,4 GiB of RAM
Comment 2 Patrick Silva 2020-01-25 14:15:11 UTC
Same thing with Dolphin 19.12.1

Operating System: Arch Linux 
KDE Plasma Version: 5.17.90
KDE Frameworks Version: 5.66.0
Qt Version: 5.14.0
Comment 3 Werner Lehmann 2020-01-26 00:04:52 UTC
Yes, it is still present with 19.12.1.
Comment 4 Justin Zobel 2021-06-21 03:15:10 UTC
Can confirm on dolphin from git master. Folders in the folder pane expand.
Comment 5 guimarcalsilva 2023-01-29 19:28:18 UTC
This bug is not present with Plasma 5.26.5 and Dolphin 22.12.2. With the option on, folders on the sidebar get opened as expected, while when it's off, they do not. I tested with multiple views, folders, and file types. I'm changing the status to RESOLVED FIXED. Werner, if you can still reproduce it, you can change it back to REPORTED and maybe include some additional information about how to reproduce it.
Comment 6 Werner Lehmann 2023-01-30 00:20:26 UTC
(In reply to guimarcalsilva from comment #5)
> This bug is not present with Plasma 5.26.5 and Dolphin 22.12.2. With the
> option on, folders on the sidebar get opened as expected, while when it's
> off, they do not. I tested with multiple views, folders, and file types. I'm

I just tested it again, on Dolphin 22.12.1. Behaviour is unchanged on this version. The configuration option has an effect when dragging files over folders inside the file pane. Behaviour depends on the option then. But it does not when dragging files from the file pane to the folder pane. Anyway, maybe it was fixed with 22.12.2. I will test it again as soon as I get that version.
Comment 7 Werner Lehmann 2023-02-05 13:47:11 UTC
guimarcalsilva, I am changing status to REPORTED as per your suggestion because on Dolphin 22.12.2, currently on Fedora 37, the issue is reproducible unchanged. I am not sure which additional information I could provide over the issue description. I already tried to keep it as succinct as possible. 

However, I did the next best thing and looked at the Dolphin source code on Github. The navigation option is bound to GeneralSettings::autoExpandFolders(). It affects two things:

1. The auto-activation delay in views/dolphinview.cpp:
    const int delay = GeneralSettings::autoExpandFolders() ? 750 : -1;
    m_container->controller()->setAutoActivationDelay(delay);

2. Same thing in panels/places/placespanel.cpp:
    if (GeneralSettings::autoExpandFolders()) {
        setDragAutoActivationDelay(750);
    } else {
        setDragAutoActivationDelay(0);
    }

And that's it for references to this option. Note how it uses -1 versus 0 between both code locations. Not sure if that is intended. On the other hand, panels/folders/folderspanel.cpp has this hardcoded:
        m_controller->setAutoActivationDelay(750);

So there you have it. The folders pane does not respect this setting as far as I can tell.