Bug 413469 - Fit Zoom to Project do not change zoom level
Summary: Fit Zoom to Project do not change zoom level
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface & Miscellaneous (show other bugs)
Version: 19.08.2
Platform: Debian stable Linux
: NOR normal
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-26 10:58 UTC by Pierre Nerzic
Modified: 2019-11-23 09:41 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 19.12
Sentry Crash Report:
fritzibaby: Brainstorm+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre Nerzic 2019-10-26 10:58:25 UTC
SUMMARY
I would expect that menu or button "Fit Zoom to Project" would change the zoom level accordingly.

STEPS TO REPRODUCE
1. Zoom to any part of a project with either middle mouse button, either zoom slider at the bottom right
2. Menu "Fit Zoom to Project" or button
3. The slider Zoom do not change, then the middle button of the mouse do not zoom as expected with the view but according to the current position of the zoom slider

OBSERVED RESULT
The slider Zoom do not change

EXPECTED RESULT
The zoom slider should change to match the part of the project displayed.

SOFTWARE/OS VERSIONS
kdenlive-19.08.2b-x86_64.appimage

ADDITIONAL INFORMATION
Comment 1 emohr 2019-11-03 10:55:21 UTC
Tested with Windows and AppImage 19.08.2. It works as expected.

Please try with the current Kdenlive AppImage version 19.08.2b to see if there are any packaging issues https://files.kde.org/kdenlive/release/ 

If the problem/issue doesn't occur when using the AppImage, then it's your configuration or packaging.
Comment 2 Pierre Nerzic 2019-11-05 18:22:56 UTC
Hi,

As I wrote in my report, I tested with the latest image, kdenlive-19.08.2b-x86_64.appimage, but this was on Linux Debian stable, not on Windows. It might be the reason of my problem.

On Linux, there is no "connection" between the zoom slider and the menu "Timeline/Fit zoom to project", the latter does not update the former. I just checked this again.

Many thanks for your help
Comment 3 Bug Janitor Service 2019-11-20 04:33:09 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 4 Pierre Nerzic 2019-11-20 11:21:22 UTC
I finally experimented KDenlive 19.08.3.exe on Windows, it is the very same problem :

- when I use the menu "Timeline/Fit zoom to project", there is no change in the slider at the bottom right of the screen.

So, this is not related to Linux or Windows. There is something missing in the chain of actions of this menu item.

Thanks for investigating further...
Comment 5 Pierre Nerzic 2019-11-20 14:50:52 UTC
After little research on the sources:

- Both menu and bottom toolbar button are connected to  void TimelineWidget::slotFitZoom() at https://github.com/KDE/kdenlive/blob/184a0616638707a505e0ce290b666bea1a286c4f/src/timeline2/view/timelinewidget.cpp#L159

- This method computes the scale factor, then calls TimelineController::setScaleFactorOnMouse() at https://github.com/KDE/kdenlive/blob/184a0616638707a505e0ce290b666bea1a286c4f/src/timeline2/view/timelinecontroller.cpp#L195

The latter calls emit scaleFactorChanged(); but not emit updateZoom(scale);. Is it the reason of the problem?

Best regards,
Pierre
Comment 6 emohr 2019-11-20 20:03:50 UTC
Sorry. I see what you mean. Confirmed: The zoom slider doesn't adjust according "Fit Zoom to Project". Thanks for the investigation. I'll make the dev aware of the issue.
Comment 7 Jean-Baptiste Mardelle 2019-11-21 06:45:29 UTC
Git commit c9c828b44794a8327b0c3da45c004023c82a00a5 by Jean-Baptiste Mardelle.
Committed on 21/11/2019 at 06:44.
Pushed by mardelle into branch 'release/19.12'.

Fix zoom slider not updating after zoom-fit

M  +2    -0    src/timeline2/view/timelinewidget.cpp

https://invent.kde.org/kde/kdenlive/commit/c9c828b44794a8327b0c3da45c004023c82a00a5
Comment 8 emohr 2019-11-21 17:31:38 UTC
Thank you for contribution and pointing to the source code.
Comment 9 Pierre Nerzic 2019-11-23 09:41:52 UTC
Hi all,
Good news, I checked the nightly build #365 and it looks like this bug has been fixed. This ticket can be closed now.

Many thanks for your huge work on kdenlive