Bug 413441 - QtQuick dialog: when installing an item, show the "Installing" text on the item itself, not using a passivenotification
Summary: QtQuick dialog: when installing an item, show the "Installing" text on the it...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-knewstuff
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Jeremy Whiting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-25 13:13 UTC by Nate Graham
Modified: 2019-11-07 14:05 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2019-10-25 13:13:16 UTC
the item being installed already becomes desaturated and shows a spinner. So that's the logical place to show the "Installing..." text. Right now, since it's a passiveNotification, it times out quickly leaving you wondering what's going on if the installation takes more than 7 seconds.
Comment 1 Dan Leinir Turthra Jensen 2019-11-07 14:05:44 UTC
Git commit 24ffb9cb9c11832ea54ef053bf0f0e3ec552b678 by Dan Leinir Turthra Jensen.
Committed on 07/11/2019 at 14:05.
Pushed by leinir into branch 'master'.

Add an overlay component for item activity feedback

Summary:
This is the very first steps toward allowing for better, more involved
feedback on what is happening with the items (such as download progress,
the ability to abort installations, and such things).

Also removes a now unneeded passive notification call

Test Plan:
Without this patch, as mentioned in https://bugs.kde.org/show_bug.cgi?id=413441

With this patch:
{F7746432}

Reviewers: #knewstuff, #frameworks, #plasma, ngraham

Reviewed By: ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D25189

M  +0    -2    src/qtquick/qml/Page.qml
M  +2    -12   src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
A  +77   -0    src/qtquick/qml/private/entrygriddelegates/FeedbackOverlay.qml     [License: LGPL]
M  +2    -12   src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml
M  +2    -12   src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml

https://commits.kde.org/knewstuff/24ffb9cb9c11832ea54ef053bf0f0e3ec552b678