Bug 413440 - QtQuick dialog: header label on item detail page probably needs Layout.fillWidth: true set on it
Summary: QtQuick dialog: header label on item detail page probably needs Layout.fillWi...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-knewstuff
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Jeremy Whiting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-25 13:10 UTC by Nate Graham
Modified: 2019-11-05 20:43 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Elided text (123.03 KB, image/png)
2019-10-25 13:10 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2019-10-25 13:10:45 UTC
Created attachment 123478 [details]
Elided text

...Because right now it elides, and the Install button isn't pushed over all the way to the right like it should be. See attached screenshot.
Comment 1 Dan Leinir Turthra Jensen 2019-11-05 20:43:56 UTC
Git commit 4d56727cc7d76c18742f97782ebf3ab6d44391be by Dan Leinir Turthra Jensen.
Committed on 05/11/2019 at 20:43.
Pushed by leinir into branch 'master'.

Fix the header layouts for EntryDetails and Page components

Summary:
This ensures that the header is the correct width, and further that
the text does not disappear when there is no space for the text (so
that it elides as intended).
Related: bug 413433

Test Plan:
Without patch: Resize a dialog to make the text not fit, and it disappears
With patch: Resize dialog, text is elided as one would expect, and the header row takes up the correct amount of space

Reviewers: ngraham, #knewstuff, #frameworks, #plasma

Reviewed By: ngraham

Subscribers: ahiemstra, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D25067

M  +30   -46   src/qtquick/qml/EntryDetails.qml
M  +1    -7    src/qtquick/qml/Page.qml

https://commits.kde.org/knewstuff/4d56727cc7d76c18742f97782ebf3ab6d44391be