Bug 413437 - QtQuick dialog: Don't show "Pick your installation option" sheet when there's only one option
Summary: QtQuick dialog: Don't show "Pick your installation option" sheet when there's...
Status: RESOLVED FIXED
Alias: None
Product: frameworks-knewstuff
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Jeremy Whiting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-25 13:02 UTC by Nate Graham
Modified: 2019-11-07 09:23 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
There's only one option here (43.73 KB, image/png)
2019-10-25 13:02 UTC, Nate Graham
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2019-10-25 13:02:44 UTC
Created attachment 123476 [details]
There's only one option here

It's unnecessary
Comment 1 Dan Leinir Turthra Jensen 2019-10-30 11:08:20 UTC
Confirm - there's in fact code which attempts to alleviate this, but it looks at the wrong bit of the model. Patch incoming shortly.
Comment 2 Dan Leinir Turthra Jensen 2019-11-07 09:23:54 UTC
Git commit 7de5ad66fd89f89a2e4a0f3884a4bea2d30ea9da by Dan Leinir Turthra Jensen.
Committed on 07/11/2019 at 09:23.
Pushed by leinir into branch 'master'.

Only show DownloadItemsSheet if there's more than one download item

Summary:
This was caused by using the downloadCount (which is the total number of times the item has been downloaded), rather than the length of the list of download items.

Test Plan:
With patch: Shows "Install..." for all items (with other than one user download)
Without patch: Shows "Install..." only for items with more than one download item

Reviewers: #knewstuff, #frameworks, ngraham

Reviewed By: ngraham

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D25165

M  +2    -2    src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
M  +2    -2    src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml
M  +2    -2    src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml

https://commits.kde.org/knewstuff/7de5ad66fd89f89a2e4a0f3884a4bea2d30ea9da