Bug 413436 - QtQuick dialog: "i" icon in corner looks unnecessary
Summary: QtQuick dialog: "i" icon in corner looks unnecessary
Status: RESOLVED FIXED
Alias: None
Product: frameworks-knewstuff
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Jeremy Whiting
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-25 13:01 UTC by Nate Graham
Modified: 2019-12-10 17:09 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.66


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Graham 2019-10-25 13:01:11 UTC
Delegates have an "info" icon in the top-right corner. I'm not sure what this communicates, and it's not clickable. Would recommend removing it.
Comment 1 Dan Leinir Turthra Jensen 2019-10-29 11:19:17 UTC
Tagging in Andy here, who is the one that came up with this particular design :)
Comment 2 Nate Graham 2019-10-29 16:24:16 UTC
Presumably he intended for the info icon to be interactive in some way; maybe it would take you to the details page. But that's already accomplished by simply clicking on the delegate.

Since it provides no functionality or aesthetic enhancement, my recommendation is to remove it. :)
Comment 3 Dan Leinir Turthra Jensen 2019-12-10 16:55:59 UTC
Git commit 0784d3f42e0647661cd0149528bbafb44e7b4e77 by Dan Leinir Turthra Jensen.
Committed on 10/12/2019 at 16:55.
Pushed by leinir into branch 'master'.

Don't show the info icon on the big preview delegate

Summary:
As discussed on the VDG chat with the original author of the design,
the information icon was supposed to be an interactive component,
but as the functionality is covered already, it adds nothing new
and as such we do not need it (and it might in fact be considered
confusing, since it looks like it is special when in fact it is not).

Test Plan:
Before:
{F7808171}

After:
{F7808173}

Reviewers: #frameworks, #knewstuff, ngraham, abetts, #vdg, ndavis

Reviewed By: #vdg, ndavis

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D25855

M  +0    -25   src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml

https://commits.kde.org/knewstuff/0784d3f42e0647661cd0149528bbafb44e7b4e77