Bug 413409 - No VHDL highlight for uppercase VHDL keywords
Summary: No VHDL highlight for uppercase VHDL keywords
Status: RESOLVED FIXED
Alias: None
Product: frameworks-syntax-highlighting
Classification: Frameworks and Libraries
Component: syntax (other bugs)
Version First Reported In: 5.63.0
Platform: Manjaro Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-24 21:32 UTC by leobel96
Modified: 2019-11-02 01:40 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In: 5.64.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description leobel96 2019-10-24 21:32:11 UTC
SUMMARY


STEPS TO REPRODUCE
1. Write some VHDL keywords (ENTITY, PORT, ...) in uppercase

OBSERVED RESULT

No highlight

EXPECTED RESULT

Should be highlighted because VHDL is case-insensitive

SOFTWARE/OS VERSIONS
Linux/KDE Plasma:
(available in About System)
KDE Plasma Version: 5.16.5
KDE Frameworks Version: 5.62.0
Qt Version: 5.13.1

ADDITIONAL INFORMATION

VHDL is a case-insensitive description language and keywords can be written uppercase or lowercase. In the first case they aren't highlighted by kate.
Comment 1 Nibaldo G. 2019-11-01 09:23:34 UTC
I checked the VHDL highlighter and found a couple of rules without the insensitive flag: https://phabricator.kde.org/D25102
Comment 2 Nibaldo G. 2019-11-02 01:39:53 UTC
Git commit 5f0306281a954af832e12d4083175bbd93ca4e4d by Nibaldo González.
Committed on 02/11/2019 at 01:39.
Pushed by ngonzalez into branch 'master'.

VHDL: all keywords are insensitive

Summary:

In the VHDL highlighter all the rules have the **insensitive** flag, except two, probably by mistake.
I also add `##Alerts` in comments.

Reviewers: #framework_syntax_highlighting, dhaumann, cullmann

Reviewed By: #framework_syntax_highlighting, cullmann

Subscribers: kwrite-devel, kde-frameworks-devel

Tags: #kate, #frameworks

Differential Revision: https://phabricator.kde.org/D25102

M  +7    -0    autotests/folding/light52_tb.vhdl.fold
M  +1    -1    autotests/html/light52_muldiv.vhdl.html
M  +8    -1    autotests/html/light52_tb.vhdl.html
M  +7    -0    autotests/input/light52_tb.vhdl
M  +1    -1    autotests/reference/light52_muldiv.vhdl.ref
M  +8    -1    autotests/reference/light52_tb.vhdl.ref
M  +6    -4    data/syntax/vhdl.xml

https://commits.kde.org/syntax-highlighting/5f0306281a954af832e12d4083175bbd93ca4e4d