Bug 413374 - Untranslatable popup "timer finished"
Summary: Untranslatable popup "timer finished"
Status: REPORTED
Alias: None
Product: kdeplasma-addons
Classification: Plasma
Component: timer (show other bugs)
Version: 5.17.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-23 19:57 UTC by Alexander Potashev
Modified: 2019-12-02 12:15 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
screenshot (7.10 KB, image/jpeg)
2019-10-23 19:57 UTC, Alexander Potashev
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Potashev 2019-10-23 19:57:08 UTC
Created attachment 123444 [details]
screenshot

SUMMARY
Untranslatable popup "timer finished".

STEPS TO REPRODUCE
1. Add "timer" widget
2. Start timer
3. Wait for completion

OBSERVED RESULT
See screenshot: notification title and description in English with Russian localization 100% complete and enabled.

EXPECTED RESULT
Notification in Russian.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Christoph Feck 2019-11-21 15:10:42 UTC
The text is part of the configuration. I haven't checked if user-visible strings in kcfg.xml files can be translated.

https://cgit.kde.org/kdeplasma-addons.git/tree/applets/timer/package/contents/config/main.xml#n38

If you clear the text in the configuration page, it should default to a translated version of the "Timer finished" message.

https://cgit.kde.org/kdeplasma-addons.git/tree/applets/timer/package/contents/ui/main.qml#n115
Comment 2 Alexander Potashev 2019-12-02 12:15:25 UTC
(In reply to Christoph Feck from comment #1)
> If you clear the text in the configuration page, it should default to a
> translated version of the "Timer finished" message.

This approach works.

However many users who once saw the English message "Timer finished" and had it saved in the configuration will now get the English variant forever. In my opinion such customizable notifications should be stored in configuration as a pair {bool customized; string customNotification;}, so that for users who do not customize it the message will follow the currently selected language.