Bug 413367 - Columns width cannot be changed by users.
Summary: Columns width cannot be changed by users.
Status: RESOLVED FIXED
Alias: None
Product: KBibTeX
Classification: Applications
Component: User interface (show other bugs)
Version: 0.8.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Thomas Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-23 15:30 UTC by Antonio
Modified: 2020-02-11 07:39 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 0.11
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio 2019-10-23 15:30:32 UTC
SUMMARY

Why a user cannot decide the width of the different columns in the view?
There is no way to regulate with the mouse (for example with an user interface
like excel or other spreadsheets) how large is a column, for the title or others. 

STEPS TO REPRODUCE
1. Open KBibtex
2. Load a Bibliography File
3. Check the column width, and try to change their width from the headers.

OBSERVED RESULT
Nothing

EXPECTED RESULT
There must be the possibility for users to change the width of the columns.

SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Thomas Fischer 2019-10-28 21:12:13 UTC
Previously, there was such a feature but it had deficits and caused problem such as disappearing columns due to widths set to zero. In anticipation that a more flexible column resizing would be implemented in Qt itself instead of KBibTeX, the column configuration was considerably simplified in order to provide a working design suitable for most (but probably not for all). As of now, it does not look like this is going to happen in Qt5.

Those words said, I have re-added the feature for column resizing in an experimental branch of KBibTeX. Manual column resizing can be enabling in this version via the context menu of the header, see option "Allow manual column resizing".
This experimental version of KBibTeX is in branch 'bugs/kde413367' in my personal clone of KBibTeX:
https://cgit.kde.org/clones/kbibtex/thomasfischer/kbibtex.git/log/?h=bugs/kde413367

In case you do not know how to test this code, please have a look at this Bash script:
https://cgit.kde.org/scratch/thomasfischer/kbibtex-related.git/tree/run/run-kbibtex.sh
You can invoke it as follows to compile and run the specified development version of KBibTeX:
bash run-kbibtex.sh 'https://anongit.kde.org/clones/kbibtex/thomasfischer/kbibtex.git' 'bugs/kde413367'
Comment 2 Thomas Fischer 2019-11-25 18:15:48 UTC
Have you had the chance to test the proposed fix as explained in comment #1? Please let me know if that fixed the problem for you.
Comment 3 Bug Janitor Service 2019-12-10 04:33:09 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 4 Thomas Fischer 2019-12-12 20:08:28 UTC
(In reply to Thomas Fischer from comment #2)
> Have you had the chance to test the proposed fix as explained in comment #1?
> Please let me know if that fixed the problem for you.

I have updated further this patch, addressing minor issues when moving columns and later resetting those move operations.
https://commits.kde.org/clones/kbibtex/thomasfischer/kbibtex/7a228841e508a628c4bb8ee46231555c7d4bcb0d

Please test and confirm whether this issue can be closed.
Comment 5 Bug Janitor Service 2019-12-27 04:33:07 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 6 Thomas Fischer 2019-12-29 22:51:07 UTC
I made some updates to the code. The same "run-kbibtex.sh" command as described earlier is still valid.
Comment 7 Bug Janitor Service 2020-01-13 04:33:09 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 8 Thomas Fischer 2020-01-18 19:49:43 UTC
(In reply to Thomas Fischer from comment #6)
> I made some updates to the code. The same "run-kbibtex.sh" command as
> described earlier is still valid.
Again some fixes. Please check and confirm if problem is gone.
Comment 9 Bug Janitor Service 2020-02-02 04:33:15 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 10 Thomas Fischer 2020-02-11 07:27:37 UTC
Git commit 82fc9f68da138e3caff37323e2f9685f388cfa36 by Thomas Fischer.
Committed on 10/02/2020 at 20:16.
Pushed by thomasfischer into branch 'master'.

Allow manual column resizing and moving

As reported in bug 413367, the ability to move and resize columns in the
main list view got removed in commit 841be480cc2230bfe7ba as the code
was considered error-prone.

This commit re-introduces the ability to move/resize columns. This
feature is disabled by default and must be first activated via the
context menu on the list view's header.
It is also possible to reset any moved or resized columns to the default
setting via another menu item in the same context menu.
Related: bug 403750
FIXED-IN: 0.11

M  +2    -0    ChangeLog
M  +35   -8    src/gui/file/basicfileview.cpp

https://commits.kde.org/kbibtex/82fc9f68da138e3caff37323e2f9685f388cfa36
Comment 11 Thomas Fischer 2020-02-11 07:39:35 UTC
Git commit 844428d41259820a73ab8a5e848e703870882874 by Thomas Fischer.
Committed on 10/02/2020 at 20:16.
Pushed by thomasfischer into branch 'master'.

(Re)storing columns' width and visual index

Storing and restoring columns' with and visual index if manual column
resizing/positioning is enabled in a BasicFileView.

This change included extending struct FieldDescription with two maps for
storing colums' widths and visual indices.
Default unless changed by user is automatic balancing of column widths
with fixed ordering (logical index == visual index).
Related: bug 403750

M  +182  -160  src/config/bibtexfields.cpp
M  +2    -0    src/config/bibtexfields.h
M  +104  -24   src/gui/file/basicfileview.cpp
M  +1    -1    src/gui/file/basicfileview.h

https://commits.kde.org/kbibtex/844428d41259820a73ab8a5e848e703870882874