Bug 413249 - The settings for Night Color have no unit for Transition Duration
Summary: The settings for Night Color have no unit for Transition Duration
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: general (show other bugs)
Version: 5.17.0
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Nate Graham
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2019-10-20 17:52 UTC by han.j@protonmail.com
Modified: 2019-10-21 15:27 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.18.0


Attachments
Screenshot of Night Color settings panel. (82.97 KB, image/png)
2019-10-20 17:52 UTC, han.j@protonmail.com
Details

Note You need to log in before you can comment on or make changes to this bug.
Description han.j@protonmail.com 2019-10-20 17:52:35 UTC
Created attachment 123367 [details]
Screenshot of Night Color settings panel.

SUMMARY

As noted in the summary.

STEPS TO REPRODUCE
1. Install Plasmashell 5.17
2. Go to System Settings-> Display and Monitor -> Night Color
3. Turn on Night Color
4. Choose "Times" for Operation mode
5. Look at the field "Transition duration"

OBSERVED RESULT

Transition duration is just an integer field with no unit. (See screenshot)

EXPECTED RESULT

The unit should be denoted beside the input field.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: openSUSE Tumbleweed/Plasma 5.17.0
(available in About System)
KDE Plasma Version: 5.17.0
KDE Frameworks Version: 5.63.0
Qt Version: 5.13.1

ADDITIONAL INFORMATION

None.
Comment 1 Nate Graham 2019-10-21 01:43:32 UTC
Here's a patchL https://phabricator.kde.org/D24813
Comment 2 Nate Graham 2019-10-21 15:27:46 UTC
Git commit cd14bbc9c720a4f08ba3e1be07bade930f3f7104 by Nate Graham.
Committed on 21/10/2019 at 15:27.
Pushed by ngraham into branch 'master'.

[KCM/Night Color] Use a spinbox with an appropriate suffix for the duration

Summary:
Currently it's a text box that doesn't give you any indication of what the units are.
FIXED-IN: 5.18.0

Test Plan: {F7639735, size=full}

Reviewers: #vdg, #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D24813

M  +12   -6    kcms/nightcolor/package/contents/ui/main.qml

https://commits.kde.org/plasma-desktop/cd14bbc9c720a4f08ba3e1be07bade930f3f7104