Bug 413235 - Autostart entry defaults enabled in all DEs
Summary: Autostart entry defaults enabled in all DEs
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (show other bugs)
Version: 5.17.0
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2019-10-20 13:08 UTC by George
Modified: 2019-10-28 18:39 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.17.2


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description George 2019-10-20 13:08:19 UTC
SUMMARY
The autostart entry for Discover defaults enabled in all desktop environments. This causes people in Gnome or other DEs that also have the KDE stack installed to have two software centers at boot. Note that for comparison, Gnome Software Center's .desktop file contains "OnlyShowIn=GNOME;Unity;" which has the expected behavior of not booting within other DEs.

STEPS TO REPRODUCE
1. Install Discover
2. Log into any DE other than KDE

OBSERVED RESULT
Discover starts along with the DE's native software installer

EXPECTED RESULT
Only the software installers native to the DE start

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch (latest) w/ KDE discover-5.17.0-1
(available in About System)
KDE Plasma Version: 5.17.0-1
KDE Frameworks Version: 5.63.0-1
Qt Version: 5.13.1-2

ADDITIONAL INFORMATION
Fix is to add the following to the .desktop file (may want to add additional DEs that depend on this component):
OnlyShowIn=KDE;
Comment 1 Nate Graham 2019-10-27 23:06:11 UTC
(In reply to George from comment #0)
> Fix is to add the following to the .desktop file (may want to add additional
> DEs that depend on this component):
> OnlyShowIn=KDE;

Would you be interested in submitting a patch that does this? Here's the file in question: https://cgit.kde.org/discover.git/tree/notifier/org.kde.discover.notifier.desktop.cmake

I can help you through the process if this will be your first time contributing to KDE or an open-source project!
Comment 2 Aleix Pol 2019-10-28 18:31:16 UTC
Git commit 6bf3c252e329e2a84fbef19daaab7ced9892466b by Aleix Pol.
Committed on 28/10/2019 at 18:31.
Pushed by apol into branch 'Plasma/5.17'.

notifier: don't autostart outside of Plasma

M  +1    -0    notifier/org.kde.discover.notifier.desktop.cmake

https://commits.kde.org/discover/6bf3c252e329e2a84fbef19daaab7ced9892466b