Bug 413198 - Some color changes in GTK Applications require logout/reboot before taking effect
Summary: Some color changes in GTK Applications require logout/reboot before taking ef...
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: gtk theme (show other bugs)
Version: 5.17.90
Platform: Neon Linux
: NOR normal
Target Milestone: ---
Assignee: Aleix Pol
URL:
Keywords:
: 413584 418667 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-10-19 15:37 UTC by Alexander Ewering
Modified: 2020-05-18 21:36 UTC (History)
10 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.19
Sentry Crash Report:


Attachments
Nautilus and Gnome Disks before relogin (239.64 KB, image/png)
2020-01-25 19:45 UTC, Patrick Silva
Details
Nautilus and Gnome Disks after relogin (249.77 KB, image/png)
2020-01-25 19:45 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Ewering 2019-10-19 15:37:33 UTC
Since about 5.17.0, changes to the GTK Application Style in System Settings don't apply anymore unless one logs out and back in again.

Also, I thought I had understood from the release notes that changes to the "Global Theme" should now apply that theme to the GTK Application Style settings AUTOMATICALLY as well, which it doesn't seem to do either.
Comment 1 Björn Feber 2019-10-19 17:11:28 UTC
(In reply to Alexander Ewering from comment #0)
> Also, I thought I had understood from the release notes that changes to the
> "Global Theme" should now apply that theme to the GTK Application Style
> settings AUTOMATICALLY as well, which it doesn't seem to do either.

Only the color scheme.
Comment 2 Alexander Ewering 2019-10-19 19:22:11 UTC
(In reply to Björn Feber from comment #1)
> (In reply to Alexander Ewering from comment #0)
> > Also, I thought I had understood from the release notes that changes to the
> > "Global Theme" should now apply that theme to the GTK Application Style
> > settings AUTOMATICALLY as well, which it doesn't seem to do either.
> 
> Only the color scheme.

OK. Anyway, the first half of the report is still occuring here... i.e. I have to log out and back in for GTK applications (even newly launched ones) to use the new GTK themes selected in System Settings.
Comment 3 Mikhail Zolotukhin 2019-11-04 19:54:41 UTC
(In reply to Alexander Ewering from comment #2)
> I have to log out and back in for GTK applications (even newly launched ones)
> to use the new GTK themes selected in System Settings.

What GTK application are you using, so that the theme does not apply without logout?
Comment 4 Alexander Ewering 2019-11-04 20:05:03 UTC
(In reply to Mikhail Zolotukhin from comment #3)
> (In reply to Alexander Ewering from comment #2)
> > I have to log out and back in for GTK applications (even newly launched ones)
> > to use the new GTK themes selected in System Settings.
> 
> What GTK application are you using, so that the theme does not apply without
> logout?

I've had the problem with both Evolution and Quod Libet, I think those are the only ones that I regularly use. Thanks for looking into it.
Comment 5 Mikhail Zolotukhin 2019-11-04 20:14:35 UTC
(In reply to Alexander Ewering from comment #4)
> I've had the problem with both Evolution and Quod Libet, I think those are
> the only ones that I regularly use. Thanks for looking into it.

From what theme to what do you change, so that theme change requires logout? For example: "Breeze" to "Breeze-Dark", or "Breeze" to "Adwaita".
Comment 6 Alexander Ewering 2019-11-04 20:38:35 UTC
(In reply to Mikhail Zolotukhin from comment #5)
> (In reply to Alexander Ewering from comment #4)
> > I've had the problem with both Evolution and Quod Libet, I think those are
> > the only ones that I regularly use. Thanks for looking into it.
> 
> From what theme to what do you change, so that theme change requires logout?
> For example: "Breeze" to "Breeze-Dark", or "Breeze" to "Adwaita".

1) In System Settings -> "Global Theme", I change from "Breeze" to "Breeze Dark", and hit 'Apply'. I'm only mentioning this for completeness, as unfortunately, this doesn't seem to automatically change the GTK theme, which I think it should.
2) In "Application Style" -> "GNOME/GTK Application Style", I switch all applicable selection boxes from "Breeze" to "Breeze-Dark" (GTK2 theme, GTK3 theme, Icon theme, Fallback theme).
3) Both Evolution and Quod Libet are still using the light theme.
4) I quit both and relaunch them. They are still using the light theme.

Only logging out and logging back in and THEN relaunching them will make them use the new theme.
Comment 7 Mikhail Zolotukhin 2019-11-04 20:43:15 UTC
(In reply to Alexander Ewering from comment #6)
> "Breeze" to "Breeze-Dark" (GTK2 theme, GTK3 theme, Icon theme, Fallback theme).

Oh, I see. If you reopen evolution after theme change you should notice, that the icons are barely visible, because they are light, but theme is still light too. Is that correct?
Comment 8 Alexander Ewering 2019-11-04 20:47:27 UTC
(In reply to Mikhail Zolotukhin from comment #7)
> (In reply to Alexander Ewering from comment #6)
> > "Breeze" to "Breeze-Dark" (GTK2 theme, GTK3 theme, Icon theme, Fallback theme).
> 
> Oh, I see. If you reopen evolution after theme change you should notice,
> that the icons are barely visible, because they are light, but theme is
> still light too. Is that correct?

Yes indeed you're right. The icons seem to get updated on relaunch, but the rest of the theme doesn't.
Comment 9 Mikhail Zolotukhin 2019-11-04 20:51:24 UTC
Seems like breeze-gtk recoloring issue.
Comment 10 Patrick Silva 2020-01-25 19:45:13 UTC
Created attachment 125409 [details]
Nautilus and Gnome Disks before relogin

This annoying problem persists on Plasma 5.18 beta.
My attached screenshots show Nautilus and Gnome Disks before and after relogin
after I switch from Breeze to Breeze Dark Global theme.
Breeze Dark color scheme is immediately applied to Gnome Disks and applied a few seconds later to Nautilus if it is configured via Colors KCM.
Comment 11 Patrick Silva 2020-01-25 19:45:39 UTC
Created attachment 125410 [details]
Nautilus and Gnome Disks after relogin
Comment 12 Patrick Silva 2020-01-25 20:58:37 UTC
*** Bug 413584 has been marked as a duplicate of this bug. ***
Comment 13 Patrick Silva 2020-03-09 21:35:54 UTC
*** Bug 418667 has been marked as a duplicate of this bug. ***
Comment 14 Patrick Silva 2020-04-24 14:37:13 UTC
On Neon dev unstable, color schemes set via Colors KCM are immediately applied to GTK3 apps (nautilus and gnome disks, for example) no matter if they are running or not.
But if I change from Breeze to Breeze Dark global theme, the dark color scheme is only applied to GTK3 apps after relogin.

Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.18.80
KDE Frameworks Version: 5.70.0
Qt Version: 5.14.1
Comment 15 Patrick Silva 2020-04-25 12:54:05 UTC
I have just applied the commit https://cgit.kde.org/kde-gtk-config.git/commit/?id=a5d4ddb3b1a27ec2ee4e1b6957a98a57ad56d39c
on Neon unstable, the issue described in comment 14 is still reproducible.
Comment 16 Mikhail Zolotukhin 2020-04-25 13:04:19 UTC
(In reply to Patrick Silva from comment #15)
> I have just applied the commit
> https://cgit.kde.org/kde-gtk-config.git/commit/
> ?id=a5d4ddb3b1a27ec2ee4e1b6957a98a57ad56d39c
> on Neon unstable, the issue described in comment 14 is still reproducible.

Yes. But initially the bug was about the necessity to relogin. I proposed hiding Breeze-Dark in the list of GTK3 themes in Plasma, since you can achieve Dark variant by changing color scheme. See https://phabricator.kde.org/D29176
Comment 17 Mikhail Zolotukhin 2020-04-25 14:51:42 UTC
Git commit fd6f3bacc91e8651aae21557f0f316690e6b8852 by Mikhail Zolotukhin.
Committed on 25/04/2020 at 14:50.
Pushed by gikari into branch 'master'.

[GTK Subpage] Hide Breeze Dark for GTK3

Summary:
Given, that Breeze GTK grabs its colors from color scheme and Breeze
Dark doesn't do that creating by that confusion within the users, dark
theme should be hidden from the list of available GTK3 themes.

Keeping dark variant may be useful for other desktop environments where
there is no dynamic recoloring and there aren't any color scheme settings.

Test Plan: Check if the GTK3 combobox in Application Style > GNOME/GTK Application Style does not have the "Breeze-Dark" option.

Reviewers: cblack

Reviewed By: cblack

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D29176

M  +8    -0    kcms/style/gtkthemesmodel.cpp

https://commits.kde.org/plasma-desktop/fd6f3bacc91e8651aae21557f0f316690e6b8852
Comment 18 Alexander Ewering 2020-04-25 20:51:31 UTC
This bug is still in full effect on my system... (fully updated)

Plasma 5.18.4
Frameworks 5.69.0
Qt 5.14.1
Comment 19 Mikhail Zolotukhin 2020-04-25 20:53:07 UTC
(In reply to Alexander Ewering from comment #18)
> This bug is still in full effect on my system... (fully updated)
> 
> Plasma 5.18.4
> Frameworks 5.69.0
> Qt 5.14.1

It will be fixed in Plasma 5.19, where we introduced recoloration GTK module, so that colors are updated on the fly.
Comment 20 Alexander Ewering 2020-04-25 21:33:04 UTC
(In reply to Mikhail Zolotukhin from comment #19)
> (In reply to Alexander Ewering from comment #18)
> > This bug is still in full effect on my system... (fully updated)
> > 
> > Plasma 5.18.4
> > Frameworks 5.69.0
> > Qt 5.14.1
> 
> It will be fixed in Plasma 5.19, where we introduced recoloration GTK
> module, so that colors are updated on the fly.

That's great! And sorry for appearing impatient -- I had misunderstood the comments as "Fixed already in current release".
Comment 21 Patrick Silva 2020-05-16 13:51:31 UTC
Updated to Plasma 5.19 beta on Arch Linux and comment 14 is still reproducible.
Should I open another report? Or can we reopen this one?

Operating System: Arch Linux 
KDE Plasma Version: 5.18.90
KDE Frameworks Version: 5.70.0
Qt Version: 5.15.0 rc2
Comment 22 Mikhail Zolotukhin 2020-05-18 11:35:59 UTC
(In reply to Patrick Silva from comment #21)
> Updated to Plasma 5.19 beta on Arch Linux and comment 14 is still
> reproducible.
> Should I open another report? Or can we reopen this one?
> 
> Operating System: Arch Linux 
> KDE Plasma Version: 5.18.90
> KDE Frameworks Version: 5.70.0
> Qt Version: 5.15.0 rc2

Open a new bug
Comment 23 Patrick Silva 2020-05-18 21:36:58 UTC
done: bug 421745