Bug 413118 - Scrollbar mouse down/click on background zone not registered in Firefox
Summary: Scrollbar mouse down/click on background zone not registered in Firefox
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: gtk theme (show other bugs)
Version: 5.17.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Janet Blackquill
URL:
Keywords: regression, usability
: 413918 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-10-17 23:35 UTC by Martín Lucas Golini
Modified: 2019-11-12 19:39 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.17.3


Attachments
This shows the lack of click detection, the first time it's using the latest breeze-gtk version, after I replace the version with an older one that works fine. (3.66 MB, video/mp4)
2019-10-17 23:35 UTC, Martín Lucas Golini
Details
Patch to fix the scrollbar behavior (684 bytes, patch)
2019-10-26 20:11 UTC, Michael Walser
Details
Correct patch to fix the scrollbar behavior. (650 bytes, patch)
2019-11-06 04:48 UTC, Martín Lucas Golini
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martín Lucas Golini 2019-10-17 23:35:28 UTC
Created attachment 123295 [details]
This shows the lack of click detection, the first time it's using the latest breeze-gtk version, after I replace the version with an older one that works fine.

SUMMARY
Since at least version 5.16.90 I'm having problems registering clicks on the "background" zone of the scrollbar at least in Firefox. The problem seems to be related to this: https://github.com/KDE/breeze-gtk/commit/71a9a1f203df5c4d9bb165e9a3f57bf8265b1252 change. The background is now transparent, and seems to not register clicks on transparent zones.
This problem at least affects Firefox with breeze-gtk for GTK3. It's quite annoying since you can't quick click the scrollbar from the screen border.

STEPS TO REPRODUCE
1. Install latest version 5.17.0
2. Open Mozilla Firefox with a scrollable page.
3. Try to scroll by clicking the background zone of the scrollbar.

OBSERVED RESULT
Click not registered.

EXPECTED RESULT
Click should be registered to scroll easily.

SOFTWARE/OS VERSIONS
openSUSE Tumbleweed with latest Plasma version (5.17.0).
Comment 1 Thomas Surrel 2019-10-23 08:06:02 UTC
I can confirm this. This also makes grabbing the scrollbar with the mouse really inconvenient since you need to aim for the handle itself, you cannot just let the mouse on the screen edge (when the window is maximized) anymore.
Comment 2 Michael Walser 2019-10-26 20:11:44 UTC
Created attachment 123503 [details]
Patch to fix the scrollbar behavior

This changed scrollbar behavior really annoyed me. I tried to come up with a patch which rectifies this issue.

What I did was to remove the margin on the scrollbar element (this margin was added in D21639) and replace it with a border around the trough element. This should restore the correct behavior while not changing the visual appearance.

Please take this with a grain of salt since I have absolutely not previous GTK experience.
Comment 3 Martín Lucas Golini 2019-11-06 04:48:27 UTC
Created attachment 123746 [details]
Correct patch to fix the scrollbar behavior.

I just want to mention that the proposed patch is not correct, since the behavior is still broken for the slider click although is visually correct.
I uploaded a patch that simply reverts the changes that actually caused this bug (linked in my first post): removed the scrollbar margin, and restored the transparent border to the scrollbar slider.
Comment 4 Janet Blackquill 2019-11-08 21:16:36 UTC
Git commit be9775281fa9018e69588174856da34c96fab82e by Carson Black.
Committed on 08/11/2019 at 21:16.
Pushed by cblack into branch 'Plasma/5.17'.

[GTK3/Firefox] Fix scrollbar click region

Summary:
Scrollbars now have a click region equivalent to their visual space in Firefox.

FIXED-IN: 5.17.3

Test Plan:
Before: 5px edge on scrollbars doesn't respond to clicks.

After: 5px edge on scrollbars responds to clicks.

Reviewers: #vdg, #breeze, ngraham

Reviewed By: #vdg, #breeze, ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25180

A  +8    -0    src/gtk3/applications/_firefox.scss
M  +2    -1    src/gtk3/gtk.scss

https://commits.kde.org/breeze-gtk/be9775281fa9018e69588174856da34c96fab82e
Comment 5 Nate Graham 2019-11-12 19:39:57 UTC
*** Bug 413918 has been marked as a duplicate of this bug. ***