Bug 413028 - cancelled offline update still causes "please reboot to proceed" notification
Summary: cancelled offline update still causes "please reboot to proceed" notification
Status: RESOLVED FIXED
Alias: None
Product: Discover
Classification: Applications
Component: discover (other bugs)
Version First Reported In: 5.17.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Dan Leinir Turthra Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-16 10:25 UTC by Harald Sitter
Modified: 2019-12-02 18:26 UTC (History)
2 users (show)

See Also:
Latest Commit: https://commits.kde.org/discover/fb3a2a15d2964e6d7d920524f8ac599544c709cd
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Sitter 2019-10-16 10:25:00 UTC 
STEPS TO REPRODUCE
1. set env var for offline upgrade
2. start update
3. cancel immediately

OBSERVED RESULT
notification "please reboot"


EXPECTED RESULT
no notification, the update hasn't actually be staged!

stat /var/lib/PackageKit/prepared-update
stat: cannot stat '/var/lib/PackageKit/prepared-update': No such file or directory



SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Aleix Pol 2019-12-02 18:26:54 UTC 
Git commit fb3a2a15d2964e6d7d920524f8ac599544c709cd by Aleix Pol.
Committed on 02/12/2019 at 18:26.
Pushed by apol into branch 'Plasma/5.17'.

pk: only trigger offline updates after a successful download

M  +1    -1    libdiscover/backends/PackageKitBackend/PackageKitUpdater.cpp

https://commits.kde.org/discover/fb3a2a15d2964e6d7d920524f8ac599544c709cd