Bug 412966 - The new HSL filter makes image loses its detail when raising saturation level
Summary: The new HSL filter makes image loses its detail when raising saturation level
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Filters (other bugs)
Version First Reported In: nightly build (please specify the git hash!)
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Dmitry Kazakov
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2019-10-15 09:43 UTC by acc4commissions
Modified: 2019-10-17 15:57 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
picture (436.06 KB, image/jpeg)
2019-10-15 09:43 UTC, acc4commissions
Details

Note You need to log in before you can comment on or make changes to this bug.
Description acc4commissions 2019-10-15 09:43:38 UTC
Created attachment 123199 [details]
picture

SUMMARY
git 8b1ac0f

Type : Hue/Saturation/Lightness

The attachment picture's left is the original and the right is saturation level 50. 

I *don't* care about the stroke effect between the character and the background. 
But if you look at the hair details, it got blurry as the saturation rises.

It looks beter with 
1 legacy mode of Hue/Saturation/Lightness 
2 Hue/Saturation/Luma

I'm sorry if I'm issing something, or it's intentional.


SOFTWARE/OS VERSIONS
Windows: Win7
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 Halla Rempt 2019-10-15 09:44:52 UTC
I'll assign to Dmitry so he can take a look. It might be an unavoidable side-effect of the new algorithm.
Comment 2 Dmitry Kazakov 2019-10-16 11:16:00 UTC
Git commit cb55d6a9f8e9b1f6e8044e450972a41e96c4f0c9 by Dmitry Kazakov.
Committed on 16/10/2019 at 11:15.
Pushed by dkazakov into branch 'master'.

Fix losing contrast when adjusting 'S' curve of HSL slider

Whe shouldn't change value to fix new saturation position. Human
eye is more precise in lightness, so clamping value will be really
visible to a human eye.

Tha patch also changes the way how 'L' slider is applied. Now it also
does some compensation for 'S' to keep saturation unchanged during the
operation. Otherwise, the image loses some contrast in saturated area.

M  +38   -70   plugins/color/colorspaceextensions/kis_hsv_adjustment.cpp

https://invent.kde.org/kde/krita/commit/cb55d6a9f8e9b1f6e8044e450972a41e96c4f0c9
Comment 3 acc4commissions 2019-10-17 15:51:47 UTC
Mind if I ask until when you'll going to keep the legacy mode?
Comment 4 acc4commissions 2019-10-17 15:57:01 UTC
Asking this because rasing saturation level with legacy HSL mode looks good too, in a different way.