Bug 412940 - [qt 5.14] - dock background and rearrange button are not removed when settings panel closed
Summary: [qt 5.14] - dock background and rearrange button are not removed when setting...
Status: RESOLVED FIXED
Alias: None
Product: lattedock
Classification: Plasma
Component: application (show other bugs)
Version: 0.9.3
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Michail Vourlakos
URL:
Keywords:
: 415525 415619 415689 415714 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-10-14 15:49 UTC by Richard Ullger
Modified: 2019-12-31 10:46 UTC (History)
6 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Latte dock background and button (537.51 KB, image/png)
2019-10-14 15:49 UTC, Richard Ullger
Details
Dock on left of screen (584.71 KB, image/png)
2019-10-14 21:07 UTC, Richard Ullger
Details
Dock with normal spacing (509.55 KB, image/png)
2019-10-20 10:18 UTC, Richard Ullger
Details
Dock with spacing after settings window closed (548.62 KB, image/png)
2019-10-20 10:18 UTC, Richard Ullger
Details
My System info (2.02 KB, text/plain)
2019-12-30 12:17 UTC, Petros
Details
Debug output from latte-dock --cc -r -d (86.05 KB, text/plain)
2019-12-30 12:19 UTC, Petros
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Ullger 2019-10-14 15:49:01 UTC
Created attachment 123184 [details]
Latte dock background and button

SUMMARY


STEPS TO REPRODUCE
1. Right-click on the dock and select Dock Settings.
1a. The settings panel is displayed together with a checked blue background behind the dock and a 'Rearrange and configure your widgets' button.
2. On the settings panel, click the Close button.

OBSERVED RESULT
The settings panel is closed but the dock background and Rearrange button are not removed. See attached image.

EXPECTED RESULT
Dock background and button should be removed.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.16.90
KDE Frameworks Version: 5.63.0
Qt Version: 5.14.0
Kernel Version: 5.3.6-arch1-1-ARCH
OS Type: 64-bit
Processors: 4 × Intel® Core™ i5 CPU M 430 @ 2.27GHz
Memory: 7.5 GiB of RAM

ADDITIONAL INFORMATION
System up-to-date (kde-unstable, testing and community-testing).

Restarting latte-dock fixes the issue.
Comment 1 Michail Vourlakos 2019-10-14 16:15:52 UTC
No idea how you ended up with this.

1. Is compositing enabled?
2. Is this the first time you are using Latte?
3. If you run Latte from cmd with, latte-dock -d what is the output including when the issue appears?
Comment 2 Richard Ullger 2019-10-14 20:57:09 UTC
1. Where can I find that setting?

2. No. I have been using latte-dock for some time. It's the first time I have seen this behaviour and probably the first time I have gone into settings while running plasma 5.16.90 (5.17 beta) and QT 5.14.0beta1 from the kde-unstable repo. I also have a dock on the left of the screen which does not exhibit this behaviour.

3. Terminal output from the point of clicking the Close button on the settings panel...

[debug 21:33:09.832832] - ConfigView deleting ...
[warning 21:33:09.934934] - file:///usr/share/latte/indicators/default/package/config/config.qml:233: TypeError: Cannot read property 'optionsWidth' of null
[warning 21:33:09.934934] - file:///usr/share/latte/indicators/default/package/config/config.qml:214: TypeError: Cannot read property 'optionsWidth' of null
[warning 21:33:09.934934] - file:///usr/share/latte/indicators/default/package/config/config.qml:204: TypeError: Cannot read property 'optionsWidth' of null
[warning 21:33:09.934934] - file:///usr/share/latte/indicators/default/package/config/config.qml:108: TypeError: Cannot read property 'optionsWidth' of null
[warning 21:33:09.934934] - file:///usr/share/latte/indicators/default/package/config/config.qml:48: TypeError: Cannot read property 'optionsWidth' of null
[debug 21:33:09.9797] - Latte::QuickWindowSystem destructed
[warning 21:33:09.999999] - "" doesn't have any WindowType, assuming as NET::Normal
[warning 21:33:10.001001] - "" doesn't have any WindowType, assuming as NET::Normal
[warning 21:33:10.002002] - "" doesn't have any WindowType, assuming as NET::Normal
[debug 21:33:10.005005] - SecDockConfigView deleting ...
[debug 21:33:10.0101] - Latte::QuickWindowSystem destructed
[warning 21:33:10.028028] - "" doesn't have any WindowType, assuming as NET::Normal
[warning 21:33:10.031031] - "" doesn't have any WindowType, assuming as NET::Normal
[warning 21:33:10.052052] - "" doesn't have any WindowType, assuming as NET::Normal
[warning 21:33:10.053053] - "" doesn't have any WindowType, assuming as NET::Normal
Comment 3 Richard Ullger 2019-10-14 21:02:59 UTC
Correction to item 2, the dock on the left of the screen does exhibit the same behaviour.
Comment 4 Richard Ullger 2019-10-14 21:07:09 UTC
Created attachment 123187 [details]
Dock on left of screen
Comment 5 Richard Ullger 2019-10-14 21:15:10 UTC
System Settings > Display and Monitor > Compositor is enabled.
Comment 6 Michail Vourlakos 2019-10-20 06:18:07 UTC
If you click on the desktop in order for Dock Settings window to lose its focus and close itself, do you have the same issue?
Comment 7 Richard Ullger 2019-10-20 10:04:02 UTC
Yes, clicking on the desktop closes the settings window but leaves the dock background and Rearrange button.

Another thing I've noticed is that when you go into the latte settings, the dock becomes more spaced out with the space around the separators being increased. When the settings window is closed, this spacing doesn't return to normal.
Comment 8 Michail Vourlakos 2019-10-20 10:15:01 UTC
what is happening is that when edit mode is not returning to normal...
and I have no idea why this occurs in your system.

Only way to fix this is to build Latte from specific code branch I will tell you and find a way to chat runtime in order to send you commits in that branch and you will test them and send me back the output that is produced.
Comment 9 Richard Ullger 2019-10-20 10:18:16 UTC
Created attachment 123355 [details]
Dock with normal spacing
Comment 10 Richard Ullger 2019-10-20 10:18:53 UTC
Created attachment 123356 [details]
Dock with spacing after settings window closed
Comment 11 Michail Vourlakos 2019-10-20 10:20:31 UTC
(In reply to Richard Ullger from comment #10)
> Created attachment 123356 [details]
> Dock with spacing after settings window closed

spacing is increased under EditMode, this is normal
Comment 12 Richard Ullger 2019-10-20 11:00:26 UTC
My point was that the spacing isn't getting returned to normal after the settings window is closed.

Might provide a clue if that section of code isn't getting executed.
Comment 13 Michail Vourlakos 2019-10-20 11:07:14 UTC
(In reply to Richard Ullger from comment #12)
> My point was that the spacing isn't getting returned to normal after the
> settings window is closed.
> 
> Might provide a clue if that section of code isn't getting executed.

spacing will be fixed when the main issue is fixed... If you cant build Latte yourself the only way this could be tracked down is if that bug can be reproduced in my system. It could be Qt 5.14 which is in Beta state, qt may have made a change that creates that situation... no idea... If that is the case when Tumbleweed update its qt version to 5.14 then it may hit me also.
Comment 14 Michail Vourlakos 2019-12-24 14:37:12 UTC
*** Bug 415525 has been marked as a duplicate of this bug. ***
Comment 15 Michail Vourlakos 2019-12-28 11:34:33 UTC
*** Bug 415619 has been marked as a duplicate of this bug. ***
Comment 16 Michail Vourlakos 2019-12-29 19:44:27 UTC
*** Bug 415689 has been marked as a duplicate of this bug. ***
Comment 17 Petros 2019-12-30 12:17:29 UTC
Created attachment 124785 [details]
My System info
Comment 18 Petros 2019-12-30 12:19:22 UTC
Created attachment 124786 [details]
Debug output from latte-dock --cc -r -d

Same bug, since some days.
Comment 19 Michail Vourlakos 2019-12-30 17:15:12 UTC
Git commit 80ed729fcf0700adf6bafb534014f20ef26d78c3 by Michail Vourlakos.
Committed on 30/12/2019 at 17:13.
Pushed by mvourlakos into branch 'master'.

[qt5.14] - restore editVisual to normal

--when the view settings window is closed then the
View must return to normal mode and disable
the editMode. In qt 5.14 default states that have a "when"
property do not play well

M  +2    -1    containment/package/contents/ui/editmode/Visual.qml

https://commits.kde.org/latte-dock/80ed729fcf0700adf6bafb534014f20ef26d78c3
Comment 20 Michail Vourlakos 2019-12-30 17:25:15 UTC
Git commit 32bcf26eaf75068c112548645e5638b5e1f824ab by Michail Vourlakos.
Committed on 30/12/2019 at 17:24.
Pushed by mvourlakos into branch 'v0.9'.

[qt5.14] - restore editVisual to normal

--when the view settings window is closed then the
View must return to normal mode and disable
the editMode. In qt 5.14 default states that have a "when"
property do not play well

M  +2    -1    containment/package/contents/ui/editmode/Visual.qml

https://commits.kde.org/latte-dock/32bcf26eaf75068c112548645e5638b5e1f824ab
Comment 21 Petros 2019-12-30 18:08:17 UTC
I installed (again) latte-dock-git just to see this fixed!

Fix confirmed!

Thanks a lot Michalis.
Happy new year!!
Comment 22 Michail Vourlakos 2019-12-31 10:46:02 UTC
*** Bug 415714 has been marked as a duplicate of this bug. ***