KUserFeedback has two concepts: globally disabled enabled in $app So even though everything is pragmatically disabled by default Provider::isEnabled is true by default. In the KCM we present: globally enabled enabled in plasma (then every app would have also have its own settings) At a technical level we have a problem that our default settings for Plasma feedback is on, which makes sense if a user has explicitly enabled things globally, but doesn't make sense to have that as a default level given how things actually work. For now I will change the default plasma level so that plasma is disabled by default. As a UX level we have a big problem as it looks like it's on by default, simply because it's not disabled. The obvious "fix" of changing the default behaviour of KUserFeedback::Provider::setEnabled is going to cause issues with the non-KDE users of KUserFeedback. I don't know what the right thing to do is. Aleix proposed a kconfig backend for kuserfeedback so we can cascade and handles globals nicely. Might be the only thing that works.
Git commit 21e56d17d57d2152feb17eecf3bf1dcaea7ebfc2 by David Edmundson. Committed on 13/10/2019 at 16:38. Pushed by davidedmundson into branch 'master'. Extra force Plasma telemetry off by default Original intention was that we would be globally off by default. When enabling it would have a default setting for Plasma ready That doesn't quite work out just yet. See bug for details This is a precautionary temporary fix just to be extra safe M +4 -3 kcms/feedback/feedback.cpp https://commits.kde.org/plasma-workspace/21e56d17d57d2152feb17eecf3bf1dcaea7ebfc2
Not sure I fully understand, what would be the behavior change you need in KUserFeedback?
@volker Right now, I don't know. This whole concept of the Provider::enabled killswitch has been a bit problematic purely at a UX level. The way we currently present things in the KCM doesn't sound like things are off by default, without needing explanatory text. It's apparently confusing to devs even after explaining the situation. Hopefully that's something that can be fixed just on our side Current thread: https://phabricator.kde.org/D24635
I'm glad my confusion has some value at least. :)
Ninja edit. There was a bad bug before where opening and saving the KCM would accidentally set the plasma's feedback enablement without user changes. That had a quick patch. Only the bug about this checkbox having misleading text remains.
To me the KCM makes sense now, and there's no longer a checkbox in it at all. Is there anything left to do now?
Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone!
This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone!