Bug 412819 - main window layout not saved/restored
Summary: main window layout not saved/restored
Status: RESOLVED FIXED
Alias: None
Product: lokalize
Classification: Applications
Component: general (show other bugs)
Version: 19.08.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Simon Depiets
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-10 15:43 UTC by Piotr Keplicz
Modified: 2025-03-23 21:04 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
default window size (43.52 KB, image/png)
2019-10-10 15:43 UTC, Piotr Keplicz
Details
lokalize window maximized (82.65 KB, image/png)
2019-10-10 15:44 UTC, Piotr Keplicz
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Keplicz 2019-10-10 15:43:50 UTC
Created attachment 123130 [details]
default window size

SUMMARY

Lokalize doesn't seem to remeber the window/toolbar layout. It always starts with the list of translatable strings (left pane) very narrow, while the edit fields are enormously big.

STEPS TO REPRODUCE
1. Start lokalize

OBSERVED RESULT

Main window layout should be restored to match previous setup. At least the left  and right panes should be of equal width.

EXPECTED RESULT

Main window layout defaults to narrow string list on the left side and big edit fields on the right side.
Comment 1 Piotr Keplicz 2019-10-10 15:44:37 UTC
Created attachment 123131 [details]
lokalize window maximized
Comment 2 Balázs Meskó 2022-03-30 12:43:31 UTC
I might pick up this issue if I would get some guidance what needs to fixed. This bug is unfortunately is a dealbreaker for me as a translator.
Comment 3 Bug Janitor Service 2025-03-23 01:57:56 UTC
A possibly relevant merge request was started @ https://invent.kde.org/sdk/lokalize/-/merge_requests/212
Comment 4 fin-w 2025-03-23 11:50:32 UTC
Git commit 7286d371a0f969884ddd8800e1008dd11011dde5 by Finley Watson.
Committed on 23/03/2025 at 11:50.
Pushed by finw into branch 'master'.

Fix editor tab state save / restore

There was a mix-up with converting to and from base64 encoding,
and more broadly there are two slightly conflicting state-saving
mechanisms, one using the field "DockWidgets" within a project
to store the editor tab's QMainWindow state, and the other using
the "EditorStates" global state storage section for project
agnostic editor tab states linked only to the file name the editor
tab is editing.

I've gotten rid of use of the "DockWidgets" fields in favour of the
"EditorStates" section in the hopes that this creates more robust
and longer-term state saving, and have fixed the state saving to
at least as good as it was a few months ago (issues still remain).
Related: bug 501786

M  +1    -1    src/editortab.cpp
M  +2    -2    src/editortab.h
M  +10   -23   src/lokalizemainwindow.cpp

https://invent.kde.org/sdk/lokalize/-/commit/7286d371a0f969884ddd8800e1008dd11011dde5
Comment 5 fin-w 2025-03-23 21:04:14 UTC
Git commit 3caf17be59318d6cf0ebf77b18c0278bf8cf5fa0 by Finley Watson.
Committed on 23/03/2025 at 13:19.
Pushed by finw into branch 'release/25.04'.

Fix editor tab state save / restore

There was a mix-up with converting to and from base64 encoding,
and more broadly there are two slightly conflicting state-saving
mechanisms, one using the field "DockWidgets" within a project
to store the editor tab's QMainWindow state, and the other using
the "EditorStates" global state storage section for project
agnostic editor tab states linked only to the file name the editor
tab is editing.

I've gotten rid of use of the "DockWidgets" fields in favour of the
"EditorStates" section in the hopes that this creates more robust
and longer-term state saving, and have fixed the state saving to
at least as good as it was a few months ago (issues still remain).
Related: bug 501786
(cherry picked from commit 7286d371a0f969884ddd8800e1008dd11011dde5)

M  +1    -1    src/editortab.cpp
M  +2    -2    src/editortab.h
M  +10   -23   src/lokalizemainwindow.cpp

https://invent.kde.org/sdk/lokalize/-/commit/3caf17be59318d6cf0ebf77b18c0278bf8cf5fa0