Bug 412765 - Avoid opening more than one "get new applets" windows
Summary: Avoid opening more than one "get new applets" windows
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Widget Explorer (show other bugs)
Version: 5.16.5
Platform: Other Linux
: NOR minor
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords: junior-jobs, usability
Depends on:
Blocks:
 
Reported: 2019-10-09 14:09 UTC by postix
Modified: 2021-01-19 16:08 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.21


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description postix 2019-10-09 14:09:09 UTC
Currently when the user clicks on "get new applets" always a new window opens instead of taking the focus to the already opened one.


SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux 
KDE Plasma Version: 5.16.5
KDE Frameworks Version: 5.63.0
Qt Version: 5.13.1
Comment 1 Bug Janitor Service 2021-01-13 16:40:46 UTC
A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/570
Comment 2 Nate Graham 2021-01-19 16:07:39 UTC
Git commit 815c6ae8888a13cdb0c298ccf9adafd3bd9bc251 by Nate Graham, on behalf of Willyanto Willyanto.
Committed on 19/01/2021 at 16:07.
Pushed by ngraham into branch 'master'.

Fix opening more than one get new applets windows

A new instance WidgetExplorer is created everytime we open get new
applets window. Each and every instance of WidgetExplorer has its own
newStuffDialog. This means that downloadWidgets method will always
create new instance of QtQuickDialogWrapper due to the default value of
newStuffDialog is null.

Change newStuffDialog to static so that it will be shared to every
instances of WidgetExplorer. This prevents another get new applets
window to be opened.

M  +3    -1    components/shellprivate/widgetexplorer/widgetexplorer.cpp

https://invent.kde.org/plasma/plasma-workspace/commit/815c6ae8888a13cdb0c298ccf9adafd3bd9bc251