Since yesterday, I'm getting a crash with kate from git master. A frameworks + kate rebuild didn't help. Here's the backtrace: #0 QWidget::layout (this=0x0) at kernel/qwidget.h:131 #1 0x00007fffede17030 in KateFileTreePluginView::KateFileTreePluginView (this=0x3645190, mainWindow=0x312a8d0, plug=0x30c8200) at /data/kde/src/kate/addons/filetree/katefiletreeplugin.cpp:136 #2 0x00007fffede169cd in KateFileTreePlugin::createView (this=0x30c8200, mainWindow=0x312a8d0) at /data/kde/src/kate/addons/filetree/katefiletreeplugin.cpp:65 #3 0x0000000000472c4e in KatePluginManager::enablePluginGUI (this=0x7fffffffb8e0, item=0x9184c0, win=0x3115180, config=0x8e6a60) at /data/kde/src/kate/kate/katepluginmanager.cpp:233 #4 0x0000000000472b9c in KatePluginManager::enableAllPluginsGUI (this=0x7fffffffb8e0, win=0x3115180, config=0x8e6a60) at /data/kde/src/kate/kate/katepluginmanager.cpp:177 #5 0x000000000044dc9d in KateMainWindow::KateMainWindow (this=0x3115180, sconfig=0x8e6a60, sgroup=...) at /data/kde/src/kate/kate/katemainwindow.cpp:151 #6 0x000000000043b809 in KateApp::newMainWindow (this=0x7fffffffb850, sconfig_=0x8e6a60, sgroup_=...) at /data/kde/src/kate/kate/kateapp.cpp:366 #7 0x00000000004afd18 in KateSessionManager::loadSession (this=0x7fffffffb900, session=...) at /data/kde/src/kate/kate/session/katesessionmanager.cpp:205 #8 0x00000000004af758 in KateSessionManager::activateSession (this=0x7fffffffb900, session=..., closeAndSaveLast=false, loadNew=true) at /data/kde/src/kate/kate/session/katesessionmanager.cpp:166 #9 0x00000000004b0368 in KateSessionManager::activateSession (this=0x7fffffffb900, name=..., closeAndSaveLast=false, loadNew=true) at /data/kde/src/kate/kate/session/katesessionmanager.cpp:242 #10 0x00000000004b0504 in KateSessionManager::activateAnonymousSession (this=0x7fffffffb900) at /data/kde/src/kate/kate/session/katesessionmanager.cpp:247 #11 0x00000000004b19bc in KateSessionManager::chooseSession (this=0x7fffffffb900) at /data/kde/src/kate/kate/session/katesessionmanager.cpp:414 #12 0x000000000043a9e5 in KateApp::startupKate (this=0x7fffffffb850) at /data/kde/src/kate/kate/kateapp.cpp:150 #13 0x000000000043a5c5 in KateApp::init (this=0x7fffffffb850) at /data/kde/src/kate/kate/kateapp.cpp:107 #14 0x00000000004337fb in main (argc=1, argv=0x7fffffffcb18) at /data/kde/src/kate/kate/main.cpp:596
After renaming anonymous.katesession in $HOME/.local/share/kate I'm able to start kate again. I'm keeping the file for investigation
Hmm, this is strange :/ The layout should be there as it is the first thing one creates in the constructor of the toolview. But perhaps I am mistaken :/
Without surprise, setting katefiletree to false in this file helps
Hmm, strange :/
I tried Kate master, with these libs KDE Frameworks 5.63.0 Qt 5.13.0 (built against 5.13.0) The xcb windowing system => I get no crash I will try to change a bit code, could you afterwards retry this?
Git commit b795da45dfa6a8624fa099696398f266ba7190be by Christoph Cullmann. Committed on 08/10/2019 at 08:14. Pushed by cullmann into branch 'master'. try to avoid nested layouts that we don't need M +0 -9 addons/filetree/katefiletreeplugin.cpp https://invent.kde.org/kde/kate/commit/b795da45dfa6a8624fa099696398f266ba7190be
Git commit b795da45dfa6a8624fa099696398f266ba7190be by Christoph Cullmann. Committed on 08/10/2019 at 08:14. Pushed by scmsync into branch 'master'. try to avoid nested layouts that we don't need M +0 -9 addons/filetree/katefiletreeplugin.cpp https://commits.kde.org/kate/b795da45dfa6a8624fa099696398f266ba7190be
One thing I remember: a few days ago, I deleted katerc because I didn't have the "Documents" tab anymore when starting kate. I then reconfigured the application and reenabled all the plugins.
(In reply to Christoph Cullmann from comment #5) > I tried Kate master, with these libs > > KDE Frameworks 5.63.0 > Qt 5.13.0 (built against 5.13.0) > The xcb windowing system > > => I get no crash > > I will try to change a bit code, could you afterwards retry this? Tested successfully.
Hmm, ok, have you a bit of time? I will do an additional commit. Could you locally try that one but revert my b795da45dfa6a8624fa099696398f266ba7190be commit?
Git commit 8b28d1e050125d4a45056cdcd031b8836aea5e1d by Christoph Cullmann. Committed on 08/10/2019 at 08:31. Pushed by cullmann into branch 'master'. ensure outer layout set M +6 -0 kate/katemdi.cpp https://invent.kde.org/kde/kate/commit/8b28d1e050125d4a45056cdcd031b8836aea5e1d
Git commit 8b28d1e050125d4a45056cdcd031b8836aea5e1d by Christoph Cullmann. Committed on 08/10/2019 at 08:31. Pushed by scmsync into branch 'master'. ensure outer layout set M +6 -0 kate/katemdi.cpp https://commits.kde.org/kate/8b28d1e050125d4a45056cdcd031b8836aea5e1d
testing
kate is still starting with this change and 8b28d1e reverted
Hmm, then I don't know why this was broken :/ In any case, will backport my two commits to the 19.08 branch. Can't hurt. Thanks for reporting this!
Git commit d3e413fb7c9fcf31c97b90a09aa52fb59bbbd9b6 by Christoph Cullmann. Committed on 08/10/2019 at 08:53. Pushed by cullmann into branch 'Applications/19.08'. try to avoid nested layouts that we don't need M +0 -9 addons/filetree/katefiletreeplugin.cpp https://invent.kde.org/kde/kate/commit/d3e413fb7c9fcf31c97b90a09aa52fb59bbbd9b6
Git commit 255a72f5b6b98740b92c70e6bac3fa56218c9d57 by Christoph Cullmann. Committed on 08/10/2019 at 08:53. Pushed by cullmann into branch 'Applications/19.08'. ensure outer layout set M +6 -0 kate/katemdi.cpp https://invent.kde.org/kde/kate/commit/255a72f5b6b98740b92c70e6bac3fa56218c9d57
Git commit 255a72f5b6b98740b92c70e6bac3fa56218c9d57 by Christoph Cullmann. Committed on 08/10/2019 at 08:53. Pushed by scmsync into branch 'Applications/19.08'. ensure outer layout set M +6 -0 kate/katemdi.cpp https://commits.kde.org/kate/255a72f5b6b98740b92c70e6bac3fa56218c9d57
Git commit d3e413fb7c9fcf31c97b90a09aa52fb59bbbd9b6 by Christoph Cullmann. Committed on 08/10/2019 at 08:53. Pushed by scmsync into branch 'Applications/19.08'. try to avoid nested layouts that we don't need M +0 -9 addons/filetree/katefiletreeplugin.cpp https://commits.kde.org/kate/d3e413fb7c9fcf31c97b90a09aa52fb59bbbd9b6