Bug 412638 - Inconsistent mechanism to draw annotations
Summary: Inconsistent mechanism to draw annotations
Status: CONFIRMED
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: 1.8.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2019-10-05 15:39 UTC by Simone Gaiarin
Modified: 2021-09-01 18:26 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Simone Gaiarin 2019-10-05 15:39:17 UTC
SUMMARY
To start drawing a straight line or polyline annotation the user have to:
- click a point
- release the left mouse button
- drag the pointer

To start drawing a geometrical annotation (rectangle, ellipse) the user have to:
- click a point 
- hold down the left mouse button
- drag the pointer

I think that the behaviour should be changed to "click and hold" for straight line and poly line.

SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux 
KDE Plasma Version: 5.16.4
KDE Frameworks Version: 5.61.0
Qt Version: 5.13.0
Kernel Version: 4.19.69-1-MANJARO
OS Type: 64-bit
Comment 1 Laura David Hurka 2019-10-06 01:16:23 UTC
How do you imagine "click and hold" for polyline?

I think polyline should be "click and click and click and right-click to finisch". (Btw whats polyline? I can find only polygon...)

The other annotations (straight line, shape) should allow both "click and click" and "click and drag".
Comment 2 Simone Gaiarin 2019-10-06 08:54:04 UTC
> How do you imagine "click and hold" for polyline?

Actually this is a good question.

> I think polyline should be "click and click and click and right-click to
> finisch". (Btw whats polyline? I can find only polygon...)

polyline = polygon, it is just how the internal engine name.

Probably what you propose is the best. It is how Krita does and how the free-select-tool works in gimp.
(an alternative is to have "click and hold" only for the first segment (this is how kolourpaint does), but I prefer what you propose)
So basically it is the current behavior, with the difference that now right click cancels the drawing instead of completing a non-closed line.

> The other annotations (straight line, shape) should allow both "click and
> click" and "click and drag".

This would be the optimum, but I see that neither Krita nor Kolourpaint allow "click and click" (probably makes the implementation trickier). For me having just "click and drag" is enough. It just needs to be changed for the straight line tool.


Summary from my point of view:
- Change behavior of straight line tool to "click and drag"
- Change right click behavior of polygon from "cancel adding annotation" to "complete curve even if not closed"
Comment 3 Nate Graham 2019-10-07 02:42:03 UTC
IMO they should all work with any of the following:
- Click-and-drag from point A to point B (for polyline, after releasing the button, you could then click-and-drag or just click to define point C and so on)
- Click on Point A and then Click on point B (in this case, a translucent line should appear connecting point A and the cursor to let you know what's happening"
Comment 4 witchhunter 2021-09-01 18:26:42 UTC
IMHO there is no reason to reinvent the wheel here. The solution should be copied from a CAD software.
- the click will start drawing the line. Line will follow mouse movement. Another click draws another point, and so on..
- right click ends and accepts the drawing
- doubleclick will close the polyline
- Esc will abort the drawing (and there is always undo)
This way one can draw a single line, polyline or a polygon from the same action.
- so for predefined shapes it is the same click-and-click (maybe and click-and-drag)


@Nate btw, current icon for polygon is totally misleading since it is suggesting drawing an open line for a (closed) polygon.
I was trying Enter, Space, RMB, doubleclick, even Escape to finish the line xDDD
Also the word polygon is not so common in my language, I also forgot it was closed shape.