Bug 412617 - G'Mic Boost-Fade filter outputs wrong colors
Summary: G'Mic Boost-Fade filter outputs wrong colors
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: G'Mic for Krita (other bugs)
Version First Reported In: 4.2.7
Platform: Microsoft Windows Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: amyspark
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-04 20:06 UTC by 8172635
Modified: 2020-10-26 13:28 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments
Input/preview at the top, output at the bottom (324.64 KB, image/png)
2019-10-04 20:06 UTC, 8172635
Details

Note You need to log in before you can comment on or make changes to this bug.
Description 8172635 2019-10-04 20:06:04 UTC
Created attachment 123019 [details]
Input/preview at the top, output at the bottom

SUMMARY

Boost Fade filter outputs a result that looks different than expected or seen in the preview. The result appears to be mostly magenta.
Comment 1 David REVOY 2019-10-04 21:07:06 UTC
I can reproduce with latest Krita 4.2.7-1 and latest Gmic Krita plugin appimage on GNU/Linux (Kubuntu 18.04.2).

https://www.peppercarrot.com/extras/temp/2019-10-04_screenshot_225907_net.jpg

I couln'd reproduce with the standalone Gmic_qt. I switch the report to 'confirmed' as it appears on both O.S.
Comment 2 Bug Janitor Service 2020-10-23 01:13:50 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/549
Comment 3 amyspark 2020-10-26 13:27:04 UTC
Git commit 2a586e72a8d93d682711f42cfe33eb8d9081cffd by L. E. Segovia.
Committed on 26/10/2020 at 13:25.
Pushed by lsegovia into branch 'master'.

Upgrade GMic to 2.9.2

This commit also upgrades related dependencies:

- OpenEXR to 2.5.3; previous versions have a broken pkg-config file,
which makes it unlocatable by GMic-Qt.
- ilmbase is now dropped, as it is bundled by OpenEXR.
- fftw3 has now threads enabled on Linux; it is a required library by
GMic.

I also cleaned up OpenEXR patches, as they have been upstreamed. GMic
patches related to threading were removed (see above), and the desktop
entry patch was updated to match the new source.

CCMAIL:kimageshop@kde.org

M  +0    -1    3rdparty/CMakeLists.txt
M  +0    -1    3rdparty/README.md
M  +1    -1    3rdparty/ext_fftw3/CMakeLists.txt
A  +41   -0    3rdparty/ext_gmic/0001-Add-desktop-entry.patch
M  +8    -14   3rdparty/ext_gmic/CMakeLists.txt
D  +0    -13   3rdparty/ext_gmic/cmake.diff
D  +0    -76   3rdparty/ext_gmic/desktop_icon.diff
D  +0    -22   3rdparty/ext_gmic/gmic-qt-cmake.diff
D  +0    -13   3rdparty/ext_gmic/no_threads.diff
D  +0    -22   3rdparty/ext_ilmbase/CMakeLists.txt
M  +7    -14   3rdparty/ext_openexr/CMakeLists.txt
D  +0    -13   3rdparty/ext_openexr/exr_symlink.diff
D  +0    -20   3rdparty/ext_openexr/openexr.diff
D  +0    -31   3rdparty/ext_openexr/patch_mingw.patch
D  +0    -13   3rdparty/ext_openexr/symlink.patch
M  +1    -1    build-tools/windows/build.cmd
M  +0    -1    krita/data/aboutdata/libraries.txt
M  +0    -3    packaging/macos/osxbuild.sh

https://invent.kde.org/graphics/krita/commit/2a586e72a8d93d682711f42cfe33eb8d9081cffd
Comment 4 amyspark 2020-10-26 13:28:28 UTC
Git commit 762398c0a0b4a12f31897afada1e642cec9ec1bb by L. E. Segovia.
Committed on 26/10/2020 at 13:28.
Pushed by lsegovia into branch 'krita/4.3'.

Upgrade GMic to 2.9.2

This commit also upgrades related dependencies:

- OpenEXR to 2.5.3; previous versions have a broken pkg-config file,
which makes it unlocatable by GMic-Qt.
- ilmbase is now dropped, as it is bundled by OpenEXR.
- fftw3 has now threads enabled on Linux; it is a required library by
GMic.

I also cleaned up OpenEXR patches, as they have been upstreamed. GMic
patches related to threading were removed (see above), and the desktop
entry patch was updated to match the new source.

CCMAIL:kimageshop@kde.org
(cherry picked from commit 2a586e72a8d93d682711f42cfe33eb8d9081cffd)

M  +0    -1    3rdparty/CMakeLists.txt
M  +0    -1    3rdparty/README.md
M  +1    -1    3rdparty/ext_fftw3/CMakeLists.txt
A  +41   -0    3rdparty/ext_gmic/0001-Add-desktop-entry.patch
M  +8    -14   3rdparty/ext_gmic/CMakeLists.txt
D  +0    -13   3rdparty/ext_gmic/cmake.diff
D  +0    -76   3rdparty/ext_gmic/desktop_icon.diff
D  +0    -22   3rdparty/ext_gmic/gmic-qt-cmake.diff
D  +0    -13   3rdparty/ext_gmic/no_threads.diff
D  +0    -22   3rdparty/ext_ilmbase/CMakeLists.txt
M  +7    -14   3rdparty/ext_openexr/CMakeLists.txt
D  +0    -13   3rdparty/ext_openexr/exr_symlink.diff
D  +0    -20   3rdparty/ext_openexr/openexr.diff
D  +0    -31   3rdparty/ext_openexr/patch_mingw.patch
D  +0    -13   3rdparty/ext_openexr/symlink.patch
M  +1    -1    build-tools/windows/build.cmd
M  +0    -1    krita/data/aboutdata/libraries.txt
M  +0    -3    packaging/macos/osxbuild.sh

https://invent.kde.org/graphics/krita/commit/762398c0a0b4a12f31897afada1e642cec9ec1bb