Bug 412534 - Changing nits slider doesn't update the color
Summary: Changing nits slider doesn't update the color
Status: CONFIRMED
Alias: None
Product: krita
Classification: Applications
Component: HDR (show other bugs)
Version: git master (please specify the git hash!)
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-02 12:20 UTC by Tiar
Modified: 2024-08-22 16:39 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tiar 2019-10-02 12:20:34 UTC
SUMMARY
When you change the nits value in Small Color Selector, it doesn't update the color.

STEPS TO REPRODUCE
1. Choose a color.
2. Change the nits value drastically.

OBSERVED RESULT
No change of current color.

EXPECTED RESULT
Change of current color.

SOFTWARE/OS VERSIONS
Windows: 10
Krita

 Version: 4.3.0-prealpha (git f5dd77b)
 Languages: en_US, en_US
 Hidpi: true

Qt

  Version (compiled): 5.12.5
  Version (loaded): 5.12.5

OS Information

  Build ABI: x86_64-little_endian-llp64
  Build CPU: x86_64
  CPU: x86_64
  Kernel Type: winnt
  Kernel Version: 10.0.18362
  Pretty Productname: Windows 10 (10.0)
  Product Type: windows
  Product Version: 10


Hardware Information

  GPU Acceleration: auto
  Memory: 16191 Mb
  Number of Cores: 12
  Swap Location: C:/Users/Agata/AppData/Local/Temp
Comment 1 Halla Rempt 2020-05-06 10:13:58 UTC
Is this still the case?
Comment 2 Bug Janitor Service 2020-05-21 04:33:14 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 3 Bug Janitor Service 2020-06-05 04:33:11 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!
Comment 4 Tiar 2020-10-01 13:31:30 UTC
Yes. It tries to preserve the color, but changing nits can be destructive (if the old color goes out of range) and if you move the nits slider like that and then back, the resulting color shown on the Small Color Selector will be different from the current color.

So the current behaviour is for sure wrong.

The behaviour I think would be better would be keeping the cursor of the color in the same position in the selector, so moving the nits slider slightly would slightly change the value of the color.
Comment 5 Will Stephenson 2021-12-14 12:51:15 UTC
I don't know enough about HDR painting to comment whether the expected behavior is correct, but the observed behavior is still as described.
Display is a Dell U3219Q HDR400 display with HDR on in Win10 and set up according to  https://docs.krita.org/en/general_concepts/colors/scene_linear_painting.html#scene-linear-painting

Krita

 Version: 5.0.0-beta5 (git a28b154)
 Languages: en_GB, en, en_US, en
 Hidpi: true

Qt

  Version (compiled): 5.12.12
  Version (loaded): 5.12.12

OS Information

  Build ABI: x86_64-little_endian-llp64
  Build CPU: x86_64
  CPU: x86_64
  Kernel Type: winnt
  Kernel Version: 10.0.19044
  Pretty Productname: Windows 10 (10.0)
  Product Type: windows
  Product Version: 10

OpenGL Info
 
  Vendor:  "Google Inc." 
  Renderer:  "ANGLE (NVIDIA GeForce GTX 1060 6GB Direct3D11 vs_5_0 ps_5_0)" 
  Version:  "OpenGL ES 3.0 (ANGLE 2.1.0.57ea533f79a7)" 
  Shading language:  "OpenGL ES GLSL ES 3.00 (ANGLE 2.1.0.57ea533f79a7)" 
  Requested format:  QSurfaceFormat(version 3.0, options QFlags<QSurfaceFormat::FormatOption>(DeprecatedFunctions), depthBufferSize 24, redBufferSize 10, greenBufferSize 10, blueBufferSize 10, alphaBufferSize 2, stencilBufferSize 8, samples -1, swapBehavior QSurfaceFormat::DoubleBuffer, swapInterval 0, colorSpace QSurfaceFormat::bt2020PQColorSpace, profile  QSurfaceFormat::CompatibilityProfile) 
  Current format:  QSurfaceFormat(version 3.0, options QFlags<QSurfaceFormat::FormatOption>(), depthBufferSize 24, redBufferSize 10, greenBufferSize 10, blueBufferSize 10, alphaBufferSize 2, stencilBufferSize 8, samples 0, swapBehavior QSurfaceFormat::DefaultSwapBehavior, swapInterval 0, colorSpace QSurfaceFormat::bt2020PQColorSpace, profile  QSurfaceFormat::NoProfile) 
     Version: 3.0
     Supports deprecated functions false 
     is OpenGL ES: true 
  supportsBufferMapping: true 
  supportsBufferInvalidation: false 
  Extensions: 
     "GL_EXT_color_buffer_half_float" 
     "GL_OES_EGL_image_external" 
     "GL_CHROMIUM_bind_generates_resource" 
     "GL_OES_texture_half_float" 
     "GL_EXT_disjoint_timer_query" 
     "GL_EXT_sRGB" 
     "GL_EXT_texture_storage" 
     "GL_OES_EGL_image_external_essl3" 
     "GL_EXT_debug_marker" 
     "" 
     "GL_EXT_unpack_subimage" 
     "GL_EXT_texture_format_BGRA8888" 
     "GL_OES_rgb8_rgba8" 
     "GL_CHROMIUM_bind_uniform_location" 
     "GL_ANGLE_pack_reverse_row_order" 
     "GL_EXT_blend_minmax" 
     "GL_EXT_shader_texture_lod" 
     "GL_ANGLE_robust_client_memory" 
     "GL_EXT_texture_filter_anisotropic" 
     "GL_OES_depth32" 
     "GL_EXT_texture_norm16" 
     "GL_OES_EGL_image" 
     "GL_OES_packed_depth_stencil" 
     "GL_ANGLE_translated_shader_source" 
     "GL_ANGLE_texture_compression_dxt5" 
     "GL_ANGLE_framebuffer_multisample" 
     "GL_CHROMIUM_sync_query" 
     "GL_EXT_robustness" 
     "GL_EXT_texture_compression_s3tc_srgb" 
     "GL_OES_standard_derivatives" 
     "GL_ANGLE_client_arrays" 
     "GL_EXT_occlusion_query_boolean" 
     "GL_EXT_texture_rg" 
     "GL_OES_mapbuffer" 
     "GL_ANGLE_depth_texture" 
     "GL_NV_pixel_buffer_object" 
     "GL_EXT_read_format_bgra" 
     "GL_OES_get_program_binary" 
     "GL_OES_texture_float_linear" 
     "GL_ANGLE_lossy_etc_decode" 
     "GL_EXT_discard_framebuffer" 
     "GL_EXT_color_buffer_float" 
     "GL_ANGLE_texture_compression_dxt3" 
     "GL_ANGLE_texture_usage" 
     "GL_NV_pack_subimage" 
     "GL_ANGLE_program_cache_control" 
     "GL_EXT_frag_depth" 
     "GL_NV_EGL_stream_consumer_external" 
     "GL_CHROMIUM_color_buffer_float_rgba" 
     "GL_EXT_draw_buffers" 
     "GL_OES_texture_npot" 
     "GL_OES_vertex_array_object" 
     "GL_OES_surfaceless_context" 
     "GL_KHR_debug" 
     "GL_ANGLE_framebuffer_blit" 
     "GL_NV_fence" 
     "GL_OES_compressed_ETC1_RGB8_texture" 
     "GL_OES_texture_half_float_linear" 
     "GL_CHROMIUM_color_buffer_float_rgb" 
     "GL_EXT_map_buffer_range" 
     "GL_ANGLE_instanced_arrays" 
     "GL_CHROMIUM_copy_compressed_texture" 
     "GL_ANGLE_request_extension" 
     "GL_OES_element_index_uint" 
     "GL_EXT_texture_compression_dxt1" 
     "GL_ANGLE_multiview" 
     "GL_OES_texture_float" 
     "GL_CHROMIUM_copy_texture" 

QPA OpenGL Detection Info 
  supportsDesktopGL: true 
  supportsAngleD3D11: true 
  isQtPreferAngle: true 

useBufferInvalidation (config option): false


Hardware Information

  GPU Acceleration: auto
  Memory: 32666 Mb
  Number of Cores: 24
  Swap Location: C:/Users/Will Stephenson/AppData/Local/Temp

Current Settings

  Current Swap Location: C:/Users/Will Stephenson/AppData/Local/Temp
  Current Swap Location writable: true
  Undo Enabled: true
  Undo Stack Limit: 200
  Use OpenGL: true
  Use OpenGL Texture Buffer: true
  Disable Vector Optimizations: false
  Disable AVX Optimizations: false
  Canvas State: OPENGL_SUCCESS
  Autosave Interval: 420
  Use Backup Files: true
  Number of Backups Kept: 1
  Backup File Suffix: ~
  Backup Location: Same Folder as the File
  Backup Location writable: false
  Use Win8 Pointer Input: false
  Use RightMiddleTabletButton Workaround: false
  Levels of Detail Enabled: false
  Use Zip64: false


Display Information
Number of screens: 1
	Screen: 0
		Name: \\.\DISPLAY1
		Depth: 32
		Scale: 1
		Resolution in pixels: 3840x2160
		Manufacturer: 
		Model: 
		Refresh Rate: 60

Current Settings

  Current Swap Location: C:/Users/Will Stephenson/AppData/Local/Temp
  Current Swap Location writable: true
  Undo Enabled: true
  Undo Stack Limit: 200
  Use OpenGL: true
  Use OpenGL Texture Buffer: true
  Disable Vector Optimizations: false
  Disable AVX Optimizations: false
  Canvas State: OPENGL_SUCCESS
  Autosave Interval: 420
  Use Backup Files: true
  Number of Backups Kept: 1
  Backup File Suffix: ~
  Backup Location: Same Folder as the File
  Backup Location writable: false
  Use Win8 Pointer Input: false
  Use RightMiddleTabletButton Workaround: false
  Levels of Detail Enabled: false
  Use Zip64: false


Current Settings

  Current Swap Location: C:/Users/Will Stephenson/AppData/Local/Temp
  Current Swap Location writable: true
  Undo Enabled: true
  Undo Stack Limit: 200
  Use OpenGL: true
  Use OpenGL Texture Buffer: true
  Disable Vector Optimizations: false
  Disable AVX Optimizations: false
  Canvas State: OPENGL_SUCCESS
  Autosave Interval: 420
  Use Backup Files: true
  Number of Backups Kept: 1
  Backup File Suffix: ~
  Backup Location: Same Folder as the File
  Backup Location writable: false
  Use Win8 Pointer Input: false
  Use RightMiddleTabletButton Workaround: false
  Levels of Detail Enabled: false
  Use Zip64: false



Krita 5.0.0-beta5 (git a28b154)
Windows 10
Comment 6 Halla Rempt 2021-12-14 12:53:52 UTC
Let's set to confirmed then :-)
Comment 7 Dmitry Kazakov 2024-08-22 16:39:25 UTC
Remove triaged keyword from CONFIRMED bugs