Bug 412420 - New whitespace caused by invisible toolbar
Summary: New whitespace caused by invisible toolbar
Status: VERIFIED FIXED
Alias: None
Product: kate
Classification: Applications
Component: application (show other bugs)
Version: Git
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Dominik Haumann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-28 16:05 UTC by Fabian Vogt
Modified: 2019-10-01 09:15 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Vogt 2019-09-28 16:05:29 UTC 
About a few days ago, openQA tests started failing because kate changed looks: https://openqa.opensuse.org/tests/1043504#step/kate/22

There's added whitespace between the menu bar and the tab bar. It seems to be a toolbar with only invisible items.
Comment 1 Christoph Cullmann 2019-09-28 16:16:12 UTC 
Hmm, might that be the external tools toolbar?
Comment 2 Christoph Cullmann 2019-09-28 16:16:33 UTC 
Btw., thanks for that catch!
;=) Now that you tell me that, I see that extra space here, too :P
Comment 3 Dominik Haumann 2019-09-28 19:32:34 UTC 
Yes, it's the External Tools toolbar. A bit inconvenient, since I was hoping that empty toolbars are invisible, which is not the case. We need to find another way to show external tools in the toolbar. Maybe by merging into the main toolbar...
Comment 4 Christoph Cullmann 2019-09-30 18:23:10 UTC 
Fixed with

Git commit 045c06b52ba0d2a59bbfd6f1165d134f4eab6a75 by Christoph Cullmann.
Committed on 30/09/2019 at 17:28.
Pushed by scmsync into branch 'master'.

try to have only one toolbar around

M  +2    -3    addons/externaltools/ui.rc

https://commits.kde.org/kate/045c06b52ba0d2a59bbfd6f1165d134f4eab6a75
Comment 5 Fabian Vogt 2019-10-01 09:15:09 UTC 
Confirmed! Thanks for the quick fix.