Bug 412376 - Toolbar Text Position never Under Icons
Summary: Toolbar Text Position never Under Icons
Status: RESOLVED FIXED
Alias: None
Product: partitionmanager
Classification: Applications
Component: general (show other bugs)
Version: 3.3
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Andrius Štikonas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-26 17:06 UTC by Sete
Modified: 2019-10-06 11:10 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
attachment-4837-0.html (1.54 KB, text/html)
2019-09-26 19:14 UTC, Sete
Details
partitionmanagerui.rc (3.17 KB, application/octet-stream)
2019-10-02 14:01 UTC, Sete
Details
attachment-17242-0.html (2.14 KB, text/html)
2019-10-03 18:03 UTC, Sete
Details
attachment-25401-0.html (2.13 KB, text/html)
2019-10-06 08:56 UTC, Sete
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sete 2019-09-26 17:06:30 UTC
SUMMARY
The text position of the icons in the toolbar is always the same: Alongside

STEPS TO REPRODUCE
1. Clic with secondary mouse button over the Toolbar to show the Context Menu
2. Clic on "Text Position"
3. Clic on "Text Under Icons"

OBSERVED RESULT
Text Alongside Icons

EXPECTED RESULT
Text Under Icons

SOFTWARE/OS VERSIONS
KDE Partition Manager: 3.3.1
Linux/KDE Plasma: Manjaro KDE
KDE Plasma Version: 5.16.4
KDE Frameworks Version: 5.61.0
Qt Version: 5.13.0
Kernel Version: 5.2.11-1-MANJARO

ADDITIONAL INFORMATION
Comment 1 Andrius Štikonas 2019-09-26 19:05:27 UTC
It works for me. Note that KDE Partition manager has 3 toolbars (I don't know why, this was probably before I joined the project), so you need to change settings for all 3 of them.
Comment 2 Sete 2019-09-26 19:14:01 UTC
Created attachment 122888 [details]
attachment-4837-0.html

You're right. I've changed settings for all 3 of them and it worked.
On the other hand, it doesn't make any sense to have 3 toolbars for this
application.
Thanks a lot!

On Thu, 26 Sep 2019 at 21:05, Andrius Štikonas <bugzilla_noreply@kde.org>
wrote:

> https://bugs.kde.org/show_bug.cgi?id=412376
>
> Andrius Štikonas <andrius@stikonas.eu> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>              Status|REPORTED                    |RESOLVED
>          Resolution|---                         |WORKSFORME
>
> --- Comment #1 from Andrius Štikonas <andrius@stikonas.eu> ---
> It works for me. Note that KDE Partition manager has 3 toolbars (I don't
> know
> why, this was probably before I joined the project), so you need to change
> settings for all 3 of them.
>
> --
> You are receiving this mail because:
> You reported the bug.
Comment 3 Andrius Štikonas 2019-09-26 20:01:02 UTC
That should be easy to fix.

It's just specified in a text file in XML format:

https://invent.kde.org/kde/partitionmanager/blob/master/src/gui/partitionmanagerui.rc

Do you want to try to fix it? Alternatively, a new bug can be opened.
Comment 4 Sete 2019-10-02 14:01:43 UTC
Created attachment 122979 [details]
partitionmanagerui.rc

Hi Andrius!

I'd love to collaborate with this and any other thing related to KDE but
I'm afraid my knowledge is still not good enough to do something like this.
I'm still a newbie.
I have attached what I would do, but I don't know how to test this file.
Maybe it would work or maybe it would break everything. I have no idea.
I have seen several KDE applications with the same problem ... to have more
than one toolbar with very few buttons/actions.

Greetings!

José Luis


On Thu, 26 Sep 2019 at 22:01, Andrius Štikonas <bugzilla_noreply@kde.org>
wrote:

> https://bugs.kde.org/show_bug.cgi?id=412376
>
> --- Comment #3 from Andrius Štikonas <andrius@stikonas.eu> ---
> That should be easy to fix.
>
> It's just specified in a text file in XML format:
>
>
> https://invent.kde.org/kde/partitionmanager/blob/master/src/gui/partitionmanagerui.rc
>
> Do you want to try to fix it? Alternatively, a new bug can be opened.
>
> --
> You are receiving this mail because:
> You reported the bug.
Comment 5 Andrius Štikonas 2019-10-02 18:24:37 UTC
Hi, your attached file seems to work for me.

I just copied it over to /usr/share/kxmlgui5/partitionmanager/partitionmanagerui.rc where my packager manager installed original version.

I can either commit this file for you, or you can finish this contribution yourself. In the latter case, please go to

https://invent.kde.org/kde/partitionmanager
Log in (if you don't yet have KDE Identity account, then you need to create it, see identity.kde.org)

Fork the project (there is a fork button in Gitlab)
Now you can either use git, clone the project replace the file with your version, do git commit and git push

or you can update file via gitlab's web interface, there is a replace button.

Then you can submit pull request.
Comment 6 Sete 2019-10-03 18:03:25 UTC
Created attachment 122997 [details]
attachment-17242-0.html

Hi!
It's great to know that the file works.
You can commit the file yourself, of course.
I think I have a KDE identity account.
Those things you talk ... fork, git, clone, commit, push ... I'm sure
they're not very complicated once you're used to them, but I haven't done
anything like that ever.
I'll try to know more about them soon.

Greetings!

JL

On Wed, 2 Oct 2019 at 20:24, Andrius Štikonas <bugzilla_noreply@kde.org>
wrote:

> https://bugs.kde.org/show_bug.cgi?id=412376
>
> --- Comment #5 from Andrius Štikonas <andrius@stikonas.eu> ---
> Hi, your attached file seems to work for me.
>
> I just copied it over to
> /usr/share/kxmlgui5/partitionmanager/partitionmanagerui.rc where my
> packager
> manager installed original version.
>
> I can either commit this file for you, or you can finish this contribution
> yourself. In the latter case, please go to
>
> https://invent.kde.org/kde/partitionmanager
> Log in (if you don't yet have KDE Identity account, then you need to
> create it,
> see identity.kde.org)
>
> Fork the project (there is a fork button in Gitlab)
> Now you can either use git, clone the project replace the file with your
> version, do git commit and git push
>
> or you can update file via gitlab's web interface, there is a replace
> button.
>
> Then you can submit pull request.
>
> --
> You are receiving this mail because:
> You reported the bug.
Comment 7 Andrius Štikonas 2019-10-05 10:21:53 UTC
Git commit 910de2a772a3dceb834091a687d4e977b89387e5 by Andrius Štikonas.
Committed on 05/10/2019 at 10:21.
Pushed by stikonas into branch 'master'.

Merge partition manager toolbars into one.

M  +2    -10   src/gui/partitionmanagerui.rc

https://invent.kde.org/kde/partitionmanager/commit/910de2a772a3dceb834091a687d4e977b89387e5
Comment 8 Sete 2019-10-06 08:56:07 UTC
Created attachment 123046 [details]
attachment-25401-0.html

We should do the same with Kate but I can't find how.

JL

On Sat, 5 Oct 2019 at 12:21, Andrius Štikonas <bugzilla_noreply@kde.org>
wrote:

> https://bugs.kde.org/show_bug.cgi?id=412376
>
> Andrius Štikonas <andrius@stikonas.eu> changed:
>
>            What    |Removed                     |Added
>
> ----------------------------------------------------------------------------
>          Resolution|WORKSFORME                  |FIXED
>       Latest Commit|                            |
> https://invent.kde.org/kde/
>                    |
> |partitionmanager/commit/910
>                    |
> |de2a772a3dceb834091a687d4e9
>                    |                            |77b89387e5
>
> --- Comment #7 from Andrius Štikonas <andrius@stikonas.eu> ---
> Git commit 910de2a772a3dceb834091a687d4e977b89387e5 by Andrius Štikonas.
> Committed on 05/10/2019 at 10:21.
> Pushed by stikonas into branch 'master'.
>
> Merge partition manager toolbars into one.
>
> M  +2    -10   src/gui/partitionmanagerui.rc
>
>
> https://invent.kde.org/kde/partitionmanager/commit/910de2a772a3dceb834091a687d4e977b89387e5
>
> --
> You are receiving this mail because:
> You reported the bug.
Comment 9 Andrius Štikonas 2019-10-06 11:10:16 UTC
That's up to Kate's maintainers to approve. For some projects there might make sense to have separate toolbars.

I'm not too sure about Kate, but it might be that one toolbar comes from katepart which is reused by many apps, kate, kwrite, kdevelop, kile while the other is kate specific stuff.

(In reply to Sete from comment #8)
> We should do the same with Kate but I can't find how.