Bug 412325 - calligraplan doesn't load translations from calligraplanlibs.mo
Summary: calligraplan doesn't load translations from calligraplanlibs.mo
Status: RESOLVED FIXED
Alias: None
Product: calligraplan
Classification: Applications
Component: general (show other bugs)
Version: 3.1.0
Platform: Fedora RPMs Linux
: NOR minor
Target Milestone: ---
Assignee: Dag Andersen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-25 14:51 UTC by wojnilowicz
Modified: 2020-01-15 09:40 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 3.2.3
Sentry Crash Report:


Attachments
Main window of Calligra Plan (8.49 KB, image/png)
2020-01-11 15:39 UTC, wojnilowicz
Details
Plan settings (50.12 KB, image/png)
2020-01-13 15:59 UTC, wojnilowicz
Details

Note You need to log in before you can comment on or make changes to this bug.
Description wojnilowicz 2019-09-25 14:51:07 UTC
Bug originally reported here
https://bugzilla.redhat.com/show_bug.cgi?id=1755439
Comment 1 Rex Dieter 2019-09-25 15:11:47 UTC
So folks don't have to view a 3rd-party bug tracker to see details, I'll paste in the comment:

Calligra Plan shows half of the strings untranslated in Polish language although they have translation on https://l10n.kde.org/


Version-Release number of selected component (if applicable):
3.1.0

How reproducible:
Always.

Steps to Reproduce:
1. log in non-English but quite fully translated KDE desktop environment
2. start calligraplan
3. main window appears

Actual results:
Main window's menu is in native language and buttons are in English language (see attachment). Translated strings for buttons are in calligraplanlibs.mo although they aren't displayed.

Expected results:
Main window's menu  and buttons should be in native language.


Additional info:
1) translations from calligraplan.mo are showed correctly in the application
2) I've tried to update:

calligraplan.mo
calligraplanlibs.mo

in

/usr/share/locale/pl/LC_MESSAGES/

from

https://l10n.kde.org/

but no change.
Comment 2 Burkhard Lück 2019-09-26 06:06:23 UTC
Git commit d325853c9e332a7a7faeda07b0d33021f9df7b12 by Burkhard Lück.
Committed on 26/09/2019 at 06:05.
Pushed by lueck into branch 'master'.

load translation catalog calligraplanlibs

M  +1    -0    src/libs/CMakeLists.txt

https://commits.kde.org/calligraplan/d325853c9e332a7a7faeda07b0d33021f9df7b12
Comment 3 Christoph Feck 2019-09-26 19:43:39 UTC
Thanks Burkhard! I knew it was a simple fix, but investigating it requires knowledge about the i18n stuff only you got :)
Comment 4 wojnilowicz 2020-01-11 15:39:59 UTC
Created attachment 125031 [details]
Main window of Calligra Plan

I use Calligra Plan 3.2.1 and it's still not fixed. Issue from attached image is still valid.
Comment 5 Dag Andersen 2020-01-13 08:50:14 UTC
Messages from the welcomeview was not extracted.
(These messages will be part of calligraplan.mo, not calligraplanlibs.mo)

Could you check if messages in e.g. the Task Editor is translated?
If they are, calligraplanlibs.mo is loaded correctly.
(It works for me)

Thanks for your persistence.
Comment 6 Dag Andersen 2020-01-13 08:51:00 UTC
Git commit 1022542a24a01eb1ad928363a258ad081cc08f7e by Dag Andersen.
Committed on 13/01/2020 at 08:42.
Pushed by danders into branch '3.2'.

Extract messages for welcome view
FIXED-IN: 3.2.3

M  +3    -2    src/Messages.sh

https://commits.kde.org/calligraplan/1022542a24a01eb1ad928363a258ad081cc08f7e
Comment 7 wojnilowicz 2020-01-13 15:59:00 UTC
Created attachment 125091 [details]
Plan settings

(In reply to Dag Andersen from comment #5)
> Messages from the welcomeview was not extracted.
> (These messages will be part of calligraplan.mo, not calligraplanlibs.mo)

I think, that it's worth noticing here, that Calligra Plan settings (please see attachment) aren't translated as well. Maybe they need the same kind of messages extraction.

> Could you check if messages in e.g. the Task Editor is translated?
> If they are, calligraplanlibs.mo is loaded correctly.
> (It works for me)

I see them translated as well.

> Thanks for your persistence.

You're welcome.
Comment 8 Dag Andersen 2020-01-13 18:30:24 UTC
> I think, that it's worth noticing here, that Calligra Plan settings (please
> see attachment) aren't translated as well. Maybe they need the same kind of
> messages extraction.
Indeed, fixed.
Comment 9 Dag Andersen 2020-01-15 09:40:00 UTC
Git commit a9392eb2c5f5742168e3122dc6f16ba4b63f7f24 by Dag Andersen.
Committed on 15/01/2020 at 09:38.
Pushed by danders into branch 'master'.

Extract messages for welcome view
FIXED-IN: 3.2.3
(cherry picked from commit 1022542a24a01eb1ad928363a258ad081cc08f7e)

M  +3    -2    src/Messages.sh

https://commits.kde.org/calligraplan/a9392eb2c5f5742168e3122dc6f16ba4b63f7f24