Bug 412313 - Duplicate entries on the Project View
Summary: Duplicate entries on the Project View
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: application (show other bugs)
Version: 18.12.3
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-25 10:59 UTC by satelliteprogrammer
Modified: 2019-09-29 13:55 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screenshot (981.65 KB, image/png)
2019-09-25 10:59 UTC, satelliteprogrammer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description satelliteprogrammer 2019-09-25 10:59:16 UTC
Created attachment 122858 [details]
screenshot

SUMMARY
The project view is showing duplicate entries for every file (not directories).

STEPS TO REPRODUCE
1. Open Kate (kate &) in a git repo

OBSERVED RESULT
Upon closer inspection, it can be seen that the path for each of these two files, when hovering each one, is different, where one use a double slash (//) after the parent directory and the other does not. Each entry opens the same file.

EXPECTED RESULT
Not showing duplicate entries.

SOFTWARE/OS VERSIONS
Linux 5.0.0-29
Xubuntu 19.04 under VirtualBox
Comment 1 Christoph Cullmann 2019-09-26 20:38:22 UTC
Is this some project with sub-modules?

Then this should be fixed with:

Author: Christoph Cullmann <cullmann@kde.org>  2019-04-07 13:42:02
Committer: Christoph Cullmann <cullmann@kde.org>  2019-04-08 06:57:10
Parent: ae04ae91e886d035a4b081b4471421d5a1abf00b ([kateproject] Gracefully exit when analyzer is not finished)
Child:  36b9beaa605fd8ba9f27680d53ab4304f10838ac (improve comment)
Branches: master, remotes/origin/Applications/19.04, remotes/origin/Applications/19.08, remotes/origin/expose-show-plugin-config-page, remotes/origin/external-tools-toolbar, remotes/origin/fix-dual-screen-hidpi, remotes/origin/lsp, remotes/origin/master, remotes/origin/remove-deprecated-plugins, remotes/origin/revive-externaltools-plugin
Follows: v19.03.90
Precedes: v19.04.0

    fix handling of sub modules in git rely on ls-files --recurse-submodules, there since end of 2016
    
    Summary: before this fix, submodules lead to duplicate files in the file tree for a project
    
    Test Plan:
    test e.g.
    
    https://github.com/christoph-cullmann/cullmann.io
    
    without patch: duplicated files, missing sub-modules
    
    with patch: no duplicates + sub-module files are there
    
    Subscribers: kwrite-devel
    
    Tags: #kate
    
    Differential Revision: https://phabricator.kde.org/D20343
Comment 2 Christoph Cullmann 2019-09-29 13:55:27 UTC
I think this is fixed by the below commit.