Bug 412168 - Add feedback after scanning for faces
Summary: Add feedback after scanning for faces
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Faces-Workflow (show other bugs)
Version: 7.0.0
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-09-21 19:00 UTC by MarcP
Modified: 2024-10-09 07:29 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 8.5.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description MarcP 2019-09-21 19:00:44 UTC
When scanning for new faces (or recognizing faces), at the moment the process ends, you only get a notification that the process has finished.

I thought it would be more informative if it told the number of faces detected/recognized. Something like: "43 new faces have been found". Or "25 faces have been recognized" in the case of face recognition.

It's just an idea that could be implemented, now that we are working on the face-workflow.
Comment 1 caulier.gilles 2019-12-26 17:37:58 UTC
Git commit 05b9a534d89234b7571d5dade8067c490ab896cf by Gilles Caulier.
Committed on 26/12/2019 at 17:30.
Pushed by cgilles into branch 'master'.

Faces Workflow simplication and improvements: remove face scan dialog and embed Face scan settings in People left sidebar.
disable settings view while a face job is running.
Catch face detector tool complete/cancelled signal to re-enable settings view.
By this way, this will prevent to run 2 concurrent face jobs at the same time.
Related: bug 398376, bug 380336

M  +45   -31   core/app/views/sidebar/leftsidebarwidgets.cpp
M  +1    -0    core/app/views/sidebar/leftsidebarwidgets.h
M  +1    -1    core/utilities/facemanagement/CMakeLists.txt
R  +15   -45   core/utilities/facemanagement/widgets/facescanwidget.cpp [from: core/utilities/facemanagement/widgets/facescandialog.cpp - 089% similarity]
R  +9    -11   core/utilities/facemanagement/widgets/facescanwidget.h [from: core/utilities/facemanagement/widgets/facescandialog.h - 079% similarity]
R  +8    -11   core/utilities/facemanagement/widgets/facescanwidget_p.h [from: core/utilities/facemanagement/widgets/facescandialog_p.h - 090% similarity]
M  +1    -1    core/utilities/maintenance/facesdetector.cpp
M  +3    -3    core/utilities/maintenance/facesdetector.h
M  +1    -0    core/utilities/maintenance/maintenancetool.cpp
M  +11   -3    core/utilities/maintenance/maintenancetool.h

https://invent.kde.org/kde/digikam/commit/05b9a534d89234b7571d5dade8067c490ab896cf
Comment 2 caulier.gilles 2024-10-09 04:39:30 UTC
Git commit 53b16b5bf5960cc6fced9cb5ef32b945fc541218 by Gilles Caulier.
Committed on 09/10/2024 at 04:37.
Pushed by cgilles into branch 'master'.

Face detector progress item: show total faces found when scan/recognition stages are done.
FIXED-IN: 8.5.0

M  +10   -0    core/utilities/maintenance/tools/facesmanagement/facesdetector.cpp

https://invent.kde.org/graphics/digikam/-/commit/53b16b5bf5960cc6fced9cb5ef32b945fc541218
Comment 3 caulier.gilles 2024-10-09 07:29:28 UTC
Git commit 25a423043567a17d925d257614e830bcfba9513d by Gilles Caulier.
Committed on 09/10/2024 at 07:28.
Pushed by cgilles into branch 'master'.

Show icon-view notification widget from the icon-view at end of faces scan process.

M  +5    -2    core/app/views/sidebar/peoplesidebarwidget.cpp
M  +24   -2    core/utilities/maintenance/tools/facesmanagement/facesdetector.cpp
M  +4    -0    core/utilities/maintenance/tools/facesmanagement/facesdetector.h

https://invent.kde.org/graphics/digikam/-/commit/25a423043567a17d925d257614e830bcfba9513d