Bug 412114 - Buttons to configure Weather and Comic Strip widgets have no icon
Summary: Buttons to configure Weather and Comic Strip widgets have no icon
Status: RESOLVED FIXED
Alias: None
Product: libplasma
Classification: Frameworks and Libraries
Component: components (show other bugs)
Version: 5.62.0
Platform: Arch Linux Linux
: HI normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2019-09-20 12:01 UTC by Patrick Silva
Modified: 2020-02-24 17:10 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.18.2


Attachments
screenshot (731.28 KB, image/png)
2019-09-20 12:01 UTC, Patrick Silva
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Silva 2019-09-20 12:01:30 UTC
Created attachment 122760 [details]
screenshot

STEPS TO REPRODUCE
1. right click on your wallpaper
2. click "Add widgets..."
3. search for Weather and Comic Strip and add such widgets to your desktop

OBSERVED RESULT
As we can see in the attached screenshot, "Configure..." button of Weather and Comic Strip widgets has no icon.

EXPECTED RESULT
"Configure..." button of Weather and Comic Strip widgets has an icon.

SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.16.90
KDE Frameworks Version: 5.62.0
Qt Version: 5.13.1
Comment 1 Nate Graham 2019-09-20 16:18:22 UTC
Can confirm, looks like a regression in Plasma Components.

What's actually happening here is that there are two buttons, and the one on top has no icon and is obscuring the one below that does.
Comment 2 Nate Graham 2020-01-31 21:06:35 UTC
Actually what's happening is that there's one button, but the hover/highlight/click effect isn't as long as it needs to be when there's an icon.
Comment 3 David Edmundson 2020-02-24 09:56:03 UTC
Git commit 2c7737f8fe8d9c60426df81a426557f3cd681508 by David Edmundson.
Committed on 24/02/2020 at 09:55.
Pushed by davidedmundson into branch 'Plasma/5.18'.

[applets/weather] Remove outdated extra configure button

Summary:
The containment seems to care for it correctly now

Also the old code was wrong and used anchors on an item inside a layout

Test Plan:
New applet with no configuration
Saw a configure button in the middle still (instead of two)
Clicking it worked

Reviewers: #plasma, ngraham

Reviewed By: ngraham

Subscribers: ngraham, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27529

M  +0    -8    applets/comic/package/contents/ui/main.qml
M  +0    -14   applets/weather/package/contents/ui/FullRepresentation.qml

https://commits.kde.org/kdeplasma-addons/2c7737f8fe8d9c60426df81a426557f3cd681508
Comment 4 Nate Graham 2020-02-24 17:10:31 UTC
Git commit cb46e52aad66a2b6eeb75ac0de630302729b90d4 by Nate Graham.
Committed on 24/02/2020 at 17:10.
Pushed by ngraham into branch 'Plasma/5.18'.

Use appropriate icon for unconfigured applets' "Configure..." buttons

Summary: CCBUG: 412114

Test Plan:
{F8116018}

(The icon size is too large by default but that's not a bug in this patch)

Reviewers: #plasma, davidedmundson, meven, ndavis

Reviewed By: meven, ndavis

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27530

M  +1    -0    components/containmentlayoutmanager/qml/BasicAppletContainer.qml

https://commits.kde.org/plasma-workspace/cb46e52aad66a2b6eeb75ac0de630302729b90d4